New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for url generation to accept stringified keys. #1571

Merged
merged 1 commit into from Jan 31, 2014

Conversation

Projects
None yet
2 participants
@jsmpereira
Contributor

jsmpereira commented Jan 31, 2014

No description provided.

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Jan 31, 2014

Member

Maybe just add one #to_sym to #value_to_param routing.rb#L626 instead of calling another recursive thingie? Would it work?

Member

ujifgc commented Jan 31, 2014

Maybe just add one #to_sym to #value_to_param routing.rb#L626 instead of calling another recursive thingie? Would it work?

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Jan 31, 2014

Member

No, that would not work. The patch is good.

Member

ujifgc commented Jan 31, 2014

No, that would not work. The patch is good.

ujifgc added a commit that referenced this pull request Jan 31, 2014

Merge pull request #1571 from jsmpereira/url-simbolize-keys
Allow for url generation to accept stringified keys.

@ujifgc ujifgc merged commit 9245c49 into padrino:master Jan 31, 2014

1 check failed

default The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment