New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dynamoid orm component #1574

Merged
merged 2 commits into from Feb 13, 2014

Conversation

Projects
None yet
5 participants
@nof
Contributor

nof commented Feb 3, 2014

I wrote generator for Dynamodb on AWS (use Dynamoid).
Please add this commit.

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Feb 5, 2014

Member

@nof Thanks for pull request! Sorry for the late reply.
This seems like a reasonable approach.
However, I'm not sure about dynamoDB and Dynamoid orm because I've never used them.
@padrino/core-members What do you think?

Member

namusyaka commented Feb 5, 2014

@nof Thanks for pull request! Sorry for the late reply.
This seems like a reasonable approach.
However, I'm not sure about dynamoDB and Dynamoid orm because I've never used them.
@padrino/core-members What do you think?

@dariocravero

This comment has been minimized.

Show comment
Hide comment
@dariocravero

dariocravero Feb 5, 2014

Contributor

@namusyaka I believe all ORMs are valid :) Thanks a lot @nof for the implementation!

I reckon before merging it would be good to give try it just to make sure it's all good. DynamoDB can tested locally as far as I know. Can't do that right now though :(

Contributor

dariocravero commented Feb 5, 2014

@namusyaka I believe all ORMs are valid :) Thanks a lot @nof for the implementation!

I reckon before merging it would be good to give try it just to make sure it's all good. DynamoDB can tested locally as far as I know. Can't do that right now though :(

@nof

This comment has been minimized.

Show comment
Hide comment
@nof

nof Feb 5, 2014

Contributor

Thank you for reply.

For your information, I used ananthakumaran/fake_dynamo in test.

You require FakeDynamo version is 0.1.3 to use aws-sdk and dynamoid in test.

gem install fake_dynamo --version 0.1.3
fake_dynamo --port 4567

and config/database.rb

AWS.config({
  :access_key_id => 'xxx',
  :secret_access_key => 'xxx',
  :use_ssl => false,
  :dynamo_db_endpoint => 'localhost',
  :dynamo_db_port => 4567
})
Contributor

nof commented Feb 5, 2014

Thank you for reply.

For your information, I used ananthakumaran/fake_dynamo in test.

You require FakeDynamo version is 0.1.3 to use aws-sdk and dynamoid in test.

gem install fake_dynamo --version 0.1.3
fake_dynamo --port 4567

and config/database.rb

AWS.config({
  :access_key_id => 'xxx',
  :secret_access_key => 'xxx',
  :use_ssl => false,
  :dynamo_db_endpoint => 'localhost',
  :dynamo_db_port => 4567
})
@@ -0,0 +1,48 @@
DYNAMOID = (<<-DYNAMOID) unless defined?(DYNAMOID)
AWS.config({

This comment has been minimized.

@namusyaka

namusyaka Feb 7, 2014

Member

I think more information(as comment) is needed.
For example, if use fake_dynamo, we'll need other options such as :dynamo_db_port and :use_ssl.
Please refer to this file.

@namusyaka

namusyaka Feb 7, 2014

Member

I think more information(as comment) is needed.
For example, if use fake_dynamo, we'll need other options such as :dynamo_db_port and :use_ssl.
Please refer to this file.

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Feb 7, 2014

Member

@nof @dariocravero Thanks for the tips!
I've tried out this changes, and it works well, except a few points.

  • Is padrino-tasks/dynamoid.rb not needed?
  • Failed to generate a table and its record of padrino-admin, but it may be caused by fake_dynamo.
Member

namusyaka commented Feb 7, 2014

@nof @dariocravero Thanks for the tips!
I've tried out this changes, and it works well, except a few points.

  • Is padrino-tasks/dynamoid.rb not needed?
  • Failed to generate a table and its record of padrino-admin, but it may be caused by fake_dynamo.
@nof

This comment has been minimized.

Show comment
Hide comment
@nof

nof Feb 7, 2014

Contributor

@namusyaka Thank you for review. I add informations for using fake_dynamo.

Regarding padrino-tasks/dynamoid.rb I think that it is not necessary for the following reasons:

  • Dynamoid does not have functions for migration.
  • Dynamoid makes table automatically in using for first time.

Regarding failure in padrino-admin, Please check the version of FakeDynamo is 0.1.3.

Contributor

nof commented Feb 7, 2014

@namusyaka Thank you for review. I add informations for using fake_dynamo.

Regarding padrino-tasks/dynamoid.rb I think that it is not necessary for the following reasons:

  • Dynamoid does not have functions for migration.
  • Dynamoid makes table automatically in using for first time.

Regarding failure in padrino-admin, Please check the version of FakeDynamo is 0.1.3.

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Feb 8, 2014

Member

Yeah, it works when using fake_dynamo's version 0.1.3 :)
Looks good to me.

Member

namusyaka commented Feb 8, 2014

Yeah, it works when using fake_dynamo's version 0.1.3 :)
Looks good to me.

@nesquena nesquena added this to the 0.12.1 milestone Feb 9, 2014

ujifgc added a commit that referenced this pull request Feb 13, 2014

@ujifgc ujifgc merged commit dffac89 into padrino:master Feb 13, 2014

1 check passed

default The Travis CI build passed
Details

@ujifgc ujifgc referenced this pull request Oct 3, 2016

Closed

NoBrainer support? #1969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment