New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the activerecord tasks #1602

Merged
merged 1 commit into from Feb 23, 2014

Conversation

Projects
None yet
2 participants
@namusyaka
Member

namusyaka commented Feb 21, 2014

No description provided.

@@ -255,7 +237,7 @@ def local_database?(config, &block)
case abcs[Padrino.env][:adapter]
when "mysql", "mysql2", 'em_mysql2', "oci", "oracle", 'jdbcmysql'
ActiveRecord::Base.establish_connection(abcs[Padrino.env])
File.open("#{Padrino.root}/db/#{Padrino.env}_structure.sql", "w+") { |f| f << ActiveRecord::Base.connection.structure_dump }
File.open(resolve_structure_sql, "w+"){|f| f << ActiveRecord::Base.connection.structure_dump }

This comment has been minimized.

@namusyaka

namusyaka Feb 21, 2014

Member

ActiveRecord::Base.connection.structure_dump is dead. rails/rails@a8bc72e
Should we remove this line?
Alternatively, should we look for another way?

@namusyaka

namusyaka Feb 21, 2014

Member

ActiveRecord::Base.connection.structure_dump is dead. rails/rails@a8bc72e
Should we remove this line?
Alternatively, should we look for another way?

ujifgc added a commit that referenced this pull request Feb 23, 2014

@ujifgc ujifgc merged commit 7bcff8d into master Feb 23, 2014

1 check failed

default The Travis CI build failed
Details

@ujifgc ujifgc deleted the refactor-activerecord-task branch Feb 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment