New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mini_shoulda adapter, fix tests syntax #1609

Merged
merged 1 commit into from Mar 2, 2014

Conversation

Projects
None yet
2 participants
@ujifgc
Member

ujifgc commented Feb 26, 2014

ref #1110

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Feb 26, 2014

Member

Nice job cleaning that up, that's quite a diff. I wish they had a simple colorized (green, red) output built into minitest...

Member

nesquena commented Feb 26, 2014

Nice job cleaning that up, that's quite a diff. I wish they had a simple colorized (green, red) output built into minitest...

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Feb 26, 2014

Member

Why do you hate rainbows and unicorns?

Member

ujifgc commented Feb 26, 2014

Why do you hate rainbows and unicorns?

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Feb 26, 2014

Member

Haha, I can live with magic of the pride colorizer :) I just find it funny they have that colorizer but not a simple greed/red one.

Member

nesquena commented Feb 26, 2014

Haha, I can live with magic of the pride colorizer :) I just find it funny they have that colorizer but not a simple greed/red one.

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Feb 26, 2014

Member

I guess it's a kind of statement from the author. seattlerb/minitest#139

Member

ujifgc commented Feb 26, 2014

I guess it's a kind of statement from the author. seattlerb/minitest#139

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Feb 26, 2014

Member

Interesting, I guess that explains things. Thanks for the link

Member

nesquena commented Feb 26, 2014

Interesting, I guess that explains things. Thanks for the link

ujifgc added a commit that referenced this pull request Mar 2, 2014

Merge pull request #1609 from padrino/no-shoulda
remove mini_shoulda adapter, fix tests syntax

@ujifgc ujifgc merged commit 67a78ae into master Mar 2, 2014

1 check was pending

default The Travis CI build is in progress
Details

@ujifgc ujifgc deleted the no-shoulda branch Mar 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment