New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move support_lite and locale to padrino-support gem, restructure it #1612

Merged
merged 4 commits into from Mar 6, 2014

Conversation

Projects
None yet
4 participants
@ujifgc
Member

ujifgc commented Mar 2, 2014

ref #1611

This looses the entanglement a little.

@dariocravero

This comment has been minimized.

Show comment
Hide comment
@dariocravero

dariocravero Mar 2, 2014

Contributor

Looks good to me! It's a much cleaner approach. @padrino/core-members?

Contributor

dariocravero commented Mar 2, 2014

Looks good to me! It's a much cleaner approach. @padrino/core-members?

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Mar 2, 2014

Member

Done!

Member

ujifgc commented Mar 2, 2014

Done!

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Mar 2, 2014

Member

Thank you for fast & great work!
Looks good to me!

Member

namusyaka commented Mar 2, 2014

Thank you for fast & great work!
Looks good to me!

@bhollis

This comment has been minimized.

Show comment
Hide comment
@bhollis

bhollis Mar 2, 2014

Oh, I just thought - I think padrino-core's .gemspec should have a dependency on padrino-support.

bhollis commented Mar 2, 2014

Oh, I just thought - I think padrino-core's .gemspec should have a dependency on padrino-support.

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Mar 2, 2014

Member

Done!

Member

ujifgc commented Mar 2, 2014

Done!

ujifgc added a commit that referenced this pull request Mar 6, 2014

Merge pull request #1612 from padrino/liberate-helpers
move support_lite and locale to padrino-support gem, restructure it

@ujifgc ujifgc merged commit 6c992df into master Mar 6, 2014

@ujifgc ujifgc deleted the liberate-helpers branch Mar 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment