New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router: Pass the same `env` variable down #1651

Merged
merged 1 commit into from Apr 8, 2014

Conversation

Projects
None yet
3 participants
@judofyr
Contributor

judofyr commented Apr 8, 2014

This is very useful when you're writing controller tests:

env = env_for(…)
res = app.call(env)
p env['rack.session']

This is currently impossible with the current code. I also think in
general it's a good idea to use the same env everywhere. It's quite
useful being able to pass data up and down the middleware stack.

ujifgc added a commit that referenced this pull request Apr 8, 2014

Merge pull request #1651 from judofyr/router-keep-env
Router: Pass the same `env` variable down

@ujifgc ujifgc merged commit 8223fbf into padrino:master Apr 8, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Apr 8, 2014

Member

Thanks, this conforms with Rack better.

Member

ujifgc commented Apr 8, 2014

Thanks, this conforms with Rack better.

@marcusramberg

This comment has been minimized.

Show comment
Hide comment
@marcusramberg

marcusramberg Apr 8, 2014

Contributor

Contributor

marcusramberg commented Apr 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment