New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed url when both uri_root and RACK_BASE_URI is setting #1670

Merged
merged 1 commit into from May 2, 2014

Conversation

Projects
None yet
2 participants
@tmtm
Contributor

tmtm commented May 1, 2014

When both Application#uri_root and RACK_BASE_URI environment variable is setting, Application#url() returns "uri_root/RACK_BASE_URI/controller/action". It should be "RACK_BASE_URI/uri_root/controller/action".

dariocravero added a commit that referenced this pull request May 2, 2014

Merge pull request #1670 from tmtm/fix-applicatoin-url
Fixed url when both uri_root and RACK_BASE_URI is setting

@dariocravero dariocravero merged commit 583e38a into padrino:master May 2, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@dariocravero

This comment has been minimized.

Show comment
Hide comment
@dariocravero

dariocravero May 2, 2014

Contributor

Makes sense to me and conforms to the fix on #1534 via 7b456e0. Thanks!

Contributor

dariocravero commented May 2, 2014

Makes sense to me and conforms to the fix on #1534 via 7b456e0. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment