New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change helpers to modular style for testability #1676

Merged
merged 6 commits into from May 8, 2014

Conversation

Projects
None yet
4 participants
@namusyaka
Member

namusyaka commented May 5, 2014

ref #1673
I've changed the format of helpers.rb.tt, and the generator came to create a helper test file.
However, I've found two problems.

  • steak and shoulda tests don't work even if remove this changes.
  • steak has depend on rspec-rails, and haven't been updated for a while.

What do you think about these?

Thank you!

@dariocravero

This comment has been minimized.

Show comment
Hide comment
@dariocravero

dariocravero May 5, 2014

Contributor

Looks great to me! Great work @namusyaka, thanks so much! @nesquena I think it's good to be merged. @padrino/core-members ?

Contributor

dariocravero commented May 5, 2014

Looks great to me! Great work @namusyaka, thanks so much! @nesquena I think it's good to be merged. @padrino/core-members ?

@nesquena nesquena added this to the 0.12.2 milestone May 7, 2014

ujifgc added a commit that referenced this pull request May 8, 2014

Merge pull request #1676 from padrino/change-helpers-to-modular-style
Change helpers to modular style for testability

@ujifgc ujifgc merged commit fd603eb into master May 8, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@namusyaka namusyaka deleted the change-helpers-to-modular-style branch May 9, 2014

namusyaka added a commit to namusyaka/sample_blog that referenced this pull request May 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment