New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove load_paths, lean Reloader on default prerequisites #1693

Merged
merged 2 commits into from Jun 7, 2014

Conversation

Projects
None yet
2 participants
@ujifgc
Member

ujifgc commented Jun 4, 2014

This patch is a part of fixing #1688

As I understand, initially load_paths was designed for Padrino to be able to reload files of an app. Then prerequisites was added and now load_paths partly duplicates default prerequisites of an app.

The second function of load_paths was to tamper with system variable $LOAD_PATH to tell Ruby which path can be looked at to find required file. It's not obvious to the user why some files are able to be required and some are not. I think if a user wants to require things manually and relatively, she should tamper with $LOAD_PATH herself.

In this patch I remove load_paths from Padrino core and improve the Reloader to track application prerequisites instead.

This patch will break some apps which are weird enough to remove lib, shared, models, mailers, controllers, helpers folders from dependencies and require them manually leaning on load_paths.

ujifgc added a commit that referenced this pull request Jun 7, 2014

Merge pull request #1693 from padrino/clean-load
remove load_paths, lean Reloader on default prerequisites

@ujifgc ujifgc merged commit ac58936 into master Jun 7, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

@ujifgc ujifgc deleted the clean-load branch Jun 7, 2014

@namusyaka namusyaka added this to the 0.12.3 milestone Jul 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment