New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests related to the thor generator #1741

Merged
merged 3 commits into from Aug 13, 2014

Conversation

Projects
None yet
2 participants
@namusyaka
Member

namusyaka commented Aug 13, 2014

ref #1740

namusyaka added some commits Aug 13, 2014

Update a few stubs for the thor generator
Thor has been using Readline.readline instead of $stdin.gets in this
case
Get rid of an unnecessary test
This test case is an unnecessary, because the generator will abort if model
already exists

@namusyaka namusyaka changed the title from Fix thor test to Fix tests related to the thor generator Aug 13, 2014

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Aug 13, 2014

Member

That was fast, thanks so much! Will merge this when travis turns green.

Member

nesquena commented Aug 13, 2014

That was fast, thanks so much! Will merge this when travis turns green.

nesquena added a commit that referenced this pull request Aug 13, 2014

Merge pull request #1741 from padrino/fix-thor-test
Fix tests related to the thor generator

@nesquena nesquena merged commit 6ac0114 into master Aug 13, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@nesquena nesquena deleted the fix-thor-test branch Aug 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment