New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color support for Windows #1744

Merged
merged 1 commit into from Aug 18, 2014

Conversation

Projects
None yet
2 participants
@tyabe
Contributor

tyabe commented Aug 18, 2014

We don't need win32console when working with Ruby 2.0 or later.
Because Ruby 2.0(or later) on Windows supports ANSI escape sequences.
Ref: https://bugs.ruby-lang.org/issues/6418

Fix color support for Windows
We don't need win32console when working with Ruby 2.0 or later.
Because Ruby 2.0(or later) on Windows supports ANSI escape sequences.
Ref: https://bugs.ruby-lang.org/issues/6418
# If you want colorize on Windows with Ruby 1.9, please use ansicon:
# https://github.com/adoxa/ansicon
# Other ways, add `gem 'win32console'` to your Gemfile.
if RUBY_PLATFORM =~ /mswin|mingw/ && RUBY_VERSION < '2.0' && ENV['ANSICON'].nil?

This comment has been minimized.

@namusyaka

namusyaka Aug 18, 2014

Member

Is this changing RUBY_PLATFORM =~ /mswin|mingw/ on purpose?

@namusyaka

namusyaka Aug 18, 2014

Member

Is this changing RUBY_PLATFORM =~ /mswin|mingw/ on purpose?

This comment has been minimized.

@tyabe

tyabe Aug 18, 2014

Contributor

To support mingw or VC++ compiled Ruby on both 32 and 64 bit Windows platforms.

@tyabe

tyabe Aug 18, 2014

Contributor

To support mingw or VC++ compiled Ruby on both 32 and 64 bit Windows platforms.

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Aug 18, 2014

Member

Okay, thanks!

Member

namusyaka commented Aug 18, 2014

Okay, thanks!

namusyaka added a commit that referenced this pull request Aug 18, 2014

Merge pull request #1744 from tyabe/fix_colorize
Fix color support for Windows

@namusyaka namusyaka merged commit 9125575 into padrino:master Aug 18, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@tyabe tyabe deleted the tyabe:fix_colorize branch Aug 20, 2014

@namusyaka namusyaka added this to the 0.12.4 milestone Aug 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment