New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe overloads of submit_tag #1778

Merged
merged 1 commit into from Sep 30, 2014

Conversation

Projects
None yet
2 participants
@claudiob
Contributor

claudiob commented Sep 29, 2014

Since the method accepts *args, it is useful to describe which overloads are accepted:

  • only options, or
  • caption and options

[ci skip]

Describe overloads of submit_tag
Since the method accepts `*args`, it is useful to describe which overloads are accepted:

* only providing `options`, or
* passing `caption` and `options`

[ci skip]
@claudiob

This comment has been minimized.

Show comment
Hide comment
@claudiob

claudiob Sep 29, 2014

Contributor

On a side note, the reason why I stumbled into this is because it differs from the ActionView method with the same name. In fact, to only provide options and use the "default" caption:

  • the Rails syntax is submit_tag nil, options
  • the Padrino syntax is submit_tag options

That's what brought me to the clarification above. Still, I'm curious to know what caused the decision of having this syntax 😄

Contributor

claudiob commented Sep 29, 2014

On a side note, the reason why I stumbled into this is because it differs from the ActionView method with the same name. In fact, to only provide options and use the "default" caption:

  • the Rails syntax is submit_tag nil, options
  • the Padrino syntax is submit_tag options

That's what brought me to the clarification above. Still, I'm curious to know what caused the decision of having this syntax 😄

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Sep 30, 2014

Member

Syntax change discussion, or the absence of it, is here #1318

Member

ujifgc commented Sep 30, 2014

Syntax change discussion, or the absence of it, is here #1318

ujifgc added a commit that referenced this pull request Sep 30, 2014

Merge pull request #1778 from claudiob/patch-2
Describe overloads of submit_tag

@ujifgc ujifgc merged commit 5d03f3a into padrino:master Sep 30, 2014

@claudiob claudiob deleted the claudiob:patch-2 branch Sep 30, 2014

@claudiob

This comment has been minimized.

Show comment
Hide comment
@claudiob

claudiob Sep 30, 2014

Contributor

Thanks for the clarification!

Contributor

claudiob commented Sep 30, 2014

Thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment