New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use controller's base path instead of constant name at controller test #1779

Merged
merged 3 commits into from Oct 14, 2014

Conversation

Projects
None yet
3 participants
@namusyaka
Member

namusyaka commented Sep 29, 2014

ref #1765
I changed to use the path at the test of all controllers except shoulda.
@postmodern @padrino/core-members What do you think?

@postmodern

This comment has been minimized.

Show comment
Hide comment
@postmodern

postmodern Oct 6, 2014

Contributor

👍 I'd also add get "!PATH!"

Contributor

postmodern commented Oct 6, 2014

👍 I'd also add get "!PATH!"

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Oct 8, 2014

Member

@postmodern Great idea! I implemented your idea with considering the parent option.

Member

namusyaka commented Oct 8, 2014

@postmodern Great idea! I implemented your idea with considering the parent option.

Routing#process_path_for_parent_params should be a public method
Because this is used in the controller generator

ujifgc added a commit that referenced this pull request Oct 14, 2014

Merge pull request #1779 from padrino/more-descriptive-controller-test
Use controller's base path instead of constant name at controller test

@ujifgc ujifgc merged commit 14711c5 into master Oct 14, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@namusyaka namusyaka deleted the more-descriptive-controller-test branch Oct 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment