New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the default_filters method #1781

Merged
merged 1 commit into from Oct 1, 2014

Conversation

Projects
None yet
4 participants
@namusyaka
Member

namusyaka commented Oct 1, 2014

The default_filters method seems no need to us.
Also the filter has continued to break the compatibility with Sinatra.
Thoughts?

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc Oct 1, 2014

Member

👍

Member

ujifgc commented Oct 1, 2014

👍

@tyabe

This comment has been minimized.

Show comment
Hide comment
@tyabe

tyabe Oct 1, 2014

Contributor

👍

Contributor

tyabe commented Oct 1, 2014

👍

Get rid of the default_filters method
Fixes wrong value of content-type when using css template helpers
The :default_content_type should be respected for compatibility with
Sinatra
@dariocravero

This comment has been minimized.

Show comment
Hide comment
@dariocravero

dariocravero Oct 1, 2014

Contributor

👍

Contributor

dariocravero commented Oct 1, 2014

👍

@namusyaka namusyaka added this to the 0.12.4 milestone Oct 1, 2014

@namusyaka

This comment has been minimized.

Show comment
Hide comment
@namusyaka

namusyaka Oct 1, 2014

Member

Thank you, everyone 👍

Member

namusyaka commented Oct 1, 2014

Thank you, everyone 👍

namusyaka added a commit that referenced this pull request Oct 1, 2014

Merge pull request #1781 from padrino/sinatra-compatibility
Get rid of the default_filters method

@namusyaka namusyaka merged commit fe65b1a into master Oct 1, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@namusyaka namusyaka deleted the sinatra-compatibility branch Oct 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment