New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Module#name instead of Module#to_s, fixes #2026 #2027

Merged
merged 1 commit into from May 4, 2016

Conversation

Projects
None yet
2 participants
@namusyaka
Member

namusyaka commented May 3, 2016

#2026

In Ruby-2.3, Module#_orig_klass_name will call ActiveRecord::Base#inspect on handling Delayed::Backend::ActiveRecord::Job.
We can avoid calling that by using Module#name instead.

If this approach is reasonable, we should backport this branch into 0.12.x branch.

@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc May 3, 2016

Member

Looks good. #name conveniently returns String or nil since 1.9.3.

Member

ujifgc commented May 3, 2016

Looks good. #name conveniently returns String or nil since 1.9.3.

@ujifgc ujifgc merged commit 689280e into master May 4, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

ujifgc added a commit that referenced this pull request May 4, 2016

Use Module#name instead of Module#to_s, fixes #2026 (#2027)
Conflicts:
	padrino-core/lib/padrino-core/reloader.rb

@namusyaka namusyaka deleted the fix-2026 branch May 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment