New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not override access control object when Padrino::Admin::AccessControl is registered in multiple apps #2042

Merged
merged 1 commit into from May 23, 2016

Conversation

Projects
None yet
2 participants
@nxs6
Contributor

nxs6 commented May 21, 2016

Since 0.13.2 When Padrino::Admin::AccessControl registered in multiple apps, they all share the same AccessControl::Base object instance, based on app loading order.

Such behavior looks incorrect, because access rules are defined per app, and paths are being checked relative to specific app mount point.

This patch fixes this problem.

ujifgc added a commit that referenced this pull request May 23, 2016

@ujifgc ujifgc merged commit 8cc3eb8 into padrino:master May 23, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ujifgc

This comment has been minimized.

Show comment
Hide comment
@ujifgc

ujifgc May 23, 2016

Member

Thanks.

Member

ujifgc commented May 23, 2016

Thanks.

ujifgc added a commit that referenced this pull request Sep 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment