GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The behavior seems not to overwrite params by given query until 0.13.0.beta2
I think this behavior is a bug, so fixed.
/cc @padrino/core-members Thoughts?
Prevent overwriting params by given query
I agree that the behavior is bad but I'm concerned about #to_sym on user-provided param keys.
@ujifgc How about this?
This is unnecessary array allocation inside a loop. 😁
Yep, however I think significant_variable_names may be used by users.
If I change data type of significant_variable_names on this PR, we should announce it at next releasing.
Don't symbolize given query key
Take care of this incompatible change
@ujifgc Just force pushed.