Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Erubi support #2090
Definitely not ready for merging, but looking for some feedback as I am still mostly unfamiliar with the Padrino codebase.
A couple items I feel I need some guidance on:
Finally, Erubi supports an interesting block-capture method in a yet-to-be released gem version. I'm not sure if this is something that should be supported or not.
Temporarily it could be tested by using environment variable
Yes. It should add
That code is fail-safe for when there's no rendering engine gem in the project Gemfile. It should work the same with this code not commented out.
I suggest to solve one problem at a time. Register erb extension like ERB and Erubis renderers do, then solve potential problems of having different ERB dialects with different extensions.
No. A renderer should utilize
I tinkered with Erubi a bit and I think there's no easy way to fix #1785 in this implementation.
My SafeErubi code:
referenced this pull request
Nov 16, 2016
Updated for new Tilt/Erubi versions and all tests are now passing.
I'm using it locally and it appears to work, outside of
As we have SafeBuffer there is no need to call
I have no idea why it passes the tests but it's a bug that