Skip to content

Fix ruby 3.x Regexp.new deprecation - #2277

Merged
achiurizo merged 7 commits into
masterfrom
achiurizo/ruby-3.2-deprecation
Jan 18, 2024
Merged

achiurizo merged 7 commits into
masterfrom
achiurizo/ruby-3.2-deprecation

Conversation

@achiurizo

@achiurizo achiurizo commented Jan 14, 2024 •

Copy link
Copy Markdown
Member

👋 A couple a minor fixes here in the hopes of moving further towards ruby 3.x:

  • Deprecate 2.6/2.7x (latest bundler versions support >2.7.5.203) This keeps ruby 2.7.5 for now
  • Ruby 3.3 deprecates the third argument in Regexp.new
  • reverts 23a87fd fix for jruby @ujifgc

@olleolleolle

olleolleolle commented Jan 17, 2024 •

Copy link
Copy Markdown
Contributor

This fixes #2278 (haha, repeating was nesquena said, sorry! but yay for fix!)

@achiurizo
achiurizo force-pushed the achiurizo/ruby-3.2-deprecation branch from 233c523 to d89efbf Compare January 17, 2024 16:31

@nesquena nesquena left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@achiurizo
achiurizo merged commit 3dec238 into master Jan 18, 2024
@achiurizo
achiurizo deleted the achiurizo/ruby-3.2-deprecation branch January 18, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants