New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweaking stylesheet_link_tag and javascript_include_tag (allow array input) #465

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@jacquescrocker
Contributor

jacquescrocker commented Apr 8, 2011

stylesheet_link_tag and javascript_include_tag should allow array inputs for sources (instead of argument array)

reason: Jammit's helpers pass plain arrays of js and css strings. This fix allows Jammit::Helper to work perfectly with Padrino and should provide better compatibility with other Rails plugins.

Working on a Padrino compatible version of Jammit, i'll send a pull request for possible inclusion in padrino-contrib or padrino-recipes

[padrino-helpers] stylesheet_link_tag and javascript_include_tag shou…
…ld allow array inputs for sources (instead of argument array)
@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Apr 8, 2011

Member

Thanks man!

Member

DAddYE commented Apr 8, 2011

Thanks man!

@DAddYE DAddYE closed this Apr 8, 2011

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Apr 8, 2011

Member

Awesome, I use Jammit on multiple Rails projects. Always wanted it for Padrino!

Member

nesquena commented Apr 8, 2011

Awesome, I use Jammit on multiple Rails projects. Always wanted it for Padrino!

@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Apr 8, 2011

Member

Instead of Jammit try to use https://github.com/padrino/padrino-contrib/blob/master/lib/padrino-contrib/helpers/assets_compressor.rb we use it in production with a lot of sites, and yep padrinorb.com use it ;) Enjoy

Member

DAddYE commented Apr 8, 2011

Instead of Jammit try to use https://github.com/padrino/padrino-contrib/blob/master/lib/padrino-contrib/helpers/assets_compressor.rb we use it in production with a lot of sites, and yep padrinorb.com use it ;) Enjoy

@jacquescrocker

This comment has been minimized.

Show comment
Hide comment
@jacquescrocker

jacquescrocker Apr 8, 2011

Contributor

Looks cool, but I've got a pretty powerful Jammit setup: https://github.com/railsjedi/jammit-s3

Compiles all the assets on deployment (as part of heroku deploy hook), and pushes to s3.

Jammit is also insanely awesome: http://documentcloud.github.com/jammit/. Killer features: autocompiled JST views, and glob support on the assets.yml

Contributor

jacquescrocker commented Apr 8, 2011

Looks cool, but I've got a pretty powerful Jammit setup: https://github.com/railsjedi/jammit-s3

Compiles all the assets on deployment (as part of heroku deploy hook), and pushes to s3.

Jammit is also insanely awesome: http://documentcloud.github.com/jammit/. Killer features: autocompiled JST views, and glob support on the assets.yml

@achiu

This comment has been minimized.

Show comment
Hide comment
@achiu

achiu Apr 10, 2011

Member

+1 for a jammit padrino-recipe

Member

achiu commented Apr 10, 2011

+1 for a jammit padrino-recipe

@jacquescrocker

This comment has been minimized.

Show comment
Hide comment
@jacquescrocker

jacquescrocker Apr 10, 2011

Contributor

Sounds good. I have Jammit working great with Padrino in my app currently. I'll extract the configuration into a recipe now

Contributor

jacquescrocker commented Apr 10, 2011

Sounds good. I have Jammit working great with Padrino in my app currently. I'll extract the configuration into a recipe now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment