New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mizuno and Trinidad support #676

Merged
merged 3 commits into from Jan 23, 2012

Conversation

Projects
None yet
3 participants
@skade
Member

skade commented Sep 17, 2011

Server now automatically picks them up if
they register a proper Rack::Handler.

Also suggest them in the Gemfile.

This is a preliminary request for testing, please do not merge yet, especially as Trinidad has not released their Rack support yet.

In the end, I found Mizuno the better experience, especially since it does not rely on jruby-rack.

Add Mizuno and Trinidad support
Server now automatically picks them up if
they register a proper Rack::Handler

Also suggest them in the Gemfile.
@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Sep 17, 2011

Member

This will be great to have out of the box Trinidad/Mizuno support. Once Trinidad releases their rack support, we can revisit this.

Member

nesquena commented Sep 17, 2011

This will be great to have out of the box Trinidad/Mizuno support. Once Trinidad releases their rack support, we can revisit this.

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Sep 21, 2011

Member

From the old ticket #675:

Some time ago (i don't want to dig) we had a user asking for running Padrino with Trinidad. As Trinidad seems to have emerged as a standard Rack server for JRuby, I would like to add support for that. For that reason, I asked Trinidad to implement a Rack::Handler subclass, which would enable us to simply add Trinidad for the JRuby platform instead of just resorting to Webrick.

trinidad/trinidad#29

This ticket is a reminder/notification. Should Trinidad implement this feature, I would very much like to add support for Padrino.

Regards,
Florian

Member

nesquena commented Sep 21, 2011

From the old ticket #675:

Some time ago (i don't want to dig) we had a user asking for running Padrino with Trinidad. As Trinidad seems to have emerged as a standard Rack server for JRuby, I would like to add support for that. For that reason, I asked Trinidad to implement a Rack::Handler subclass, which would enable us to simply add Trinidad for the JRuby platform instead of just resorting to Webrick.

trinidad/trinidad#29

This ticket is a reminder/notification. Should Trinidad implement this feature, I would very much like to add support for Padrino.

Regards,
Florian

@ghost ghost assigned DAddYE Sep 22, 2011

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Sep 26, 2011

Member

Moving this to 0.10.4 for now (seems its not ready yet)? Obviously we should merge this as soon as its possible and they have rack handlers.

Member

nesquena commented Sep 26, 2011

Moving this to 0.10.4 for now (seems its not ready yet)? Obviously we should merge this as soon as its possible and they have rack handlers.

@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Sep 26, 2011

Member

@skade if Mizuno is ready we can start merging it no? @nesquena?

Member

DAddYE commented Sep 26, 2011

@skade if Mizuno is ready we can start merging it no? @nesquena?

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Sep 26, 2011

Member

Is Mizuno ready? I thought it was this issue? matadon/mizuno#13

Member

nesquena commented Sep 26, 2011

Is Mizuno ready? I thought it was this issue? matadon/mizuno#13

@skade

This comment has been minimized.

Show comment
Hide comment
@skade

skade Oct 7, 2011

Member

The problem is the missing response by the trinidad-team. Maybe i'll throw out trinidad for now and just use Mizuno. I'll test it this weekend.

Member

skade commented Oct 7, 2011

The problem is the missing response by the trinidad-team. Maybe i'll throw out trinidad for now and just use Mizuno. I'll test it this weekend.

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Jan 9, 2012

Member

@skade What's the status with this, seems they've added the rack handler?

Member

nesquena commented Jan 9, 2012

@skade What's the status with this, seems they've added the rack handler?

@DAddYE DAddYE closed this Jan 22, 2012

@DAddYE DAddYE reopened this Jan 22, 2012

@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Jan 22, 2012

Member

Trinidad seems to work right now, can we add it? @skade ?

Member

DAddYE commented Jan 22, 2012

Trinidad seems to work right now, can we add it? @skade ?

Merge branch 'master' into jruby-webserver-support
Conflicts:
	padrino-gen/lib/padrino-gen/generators/templates/Gemfile.tt
@skade

This comment has been minimized.

Show comment
Hide comment
@skade

skade Jan 23, 2012

Member

I just checked and did not get mizuno or trinidad working in a fire-and-forget fashion. I'll try trinidad master next.

Member

skade commented Jan 23, 2012

I just checked and did not get mizuno or trinidad working in a fire-and-forget fashion. I'll try trinidad master next.

@skade

This comment has been minimized.

Show comment
Hide comment
@skade

skade Jan 23, 2012

Member

Sorry, my fault. Trinidad works now, still no support on the mizuno side. I pushed some updates.

Member

skade commented Jan 23, 2012

Sorry, my fault. Trinidad works now, still no support on the mizuno side. I pushed some updates.

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Jan 23, 2012

Member

Great! lets merge this in before release @DAddYE?

Member

nesquena commented Jan 23, 2012

Great! lets merge this in before release @DAddYE?

DAddYE added a commit that referenced this pull request Jan 23, 2012

@DAddYE DAddYE merged commit d5e78bd into master Jan 23, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment