New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status messages to common padrino logger #689

Merged
merged 1 commit into from Oct 5, 2011

Conversation

Projects
None yet
3 participants
@udzura
Contributor

udzura commented Oct 5, 2011

Hi, team

I like new Padrino::Logger's output very much.

Now, I think it's more useful for log's format to show a "status message" in addition to a status code.
Especially in case between status codes 301 & 302, and so on...

I'll be very happy when this small feature will be accepted!

sample is below.

http://gyazo.udzura.jp/84700c6e3a73e5f7cedce84ceedeea24.png

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Oct 5, 2011

Member

Looks great to me, thanks for the patch Uchio. Loving our new and improved logger :) What do you think @DAddYE?

Member

nesquena commented Oct 5, 2011

Looks great to me, thanks for the patch Uchio. Loving our new and improved logger :) What do you think @DAddYE?

@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Oct 5, 2011

Member

@udzura, thanks! I had planned to add it in next release but you already do that! Great!

Member

DAddYE commented Oct 5, 2011

@udzura, thanks! I had planned to add it in next release but you already do that! Great!

DAddYE added a commit that referenced this pull request Oct 5, 2011

Merge pull request #689 from udzura/logger-with-status-name
Add status codes messages to common padrino logger

@DAddYE DAddYE merged commit 8921c49 into padrino:master Oct 5, 2011

@udzura

This comment has been minimized.

Show comment
Hide comment
@udzura

udzura Oct 6, 2011

Contributor

Thank you for your pull!

Contributor

udzura commented Oct 6, 2011

Thank you for your pull!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment