New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update static resources' url from https://github.com to https://raw.github.com #701

Merged
merged 2 commits into from Oct 13, 2011

Conversation

Projects
None yet
2 participants
@elmer
Contributor

elmer commented Oct 13, 2011

switch download of raw resources from https://github.com/ to https://raw.github.com/

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Oct 13, 2011

Member

When I visit: https://raw.github.com/padrino/padrino-static/raw/master/js/dojo.js I get a 404 response. When I visit the old https://github.com/padrino/padrino-static/raw/master/js/dojo.js it seems to work...

Member

nesquena commented Oct 13, 2011

When I visit: https://raw.github.com/padrino/padrino-static/raw/master/js/dojo.js I get a 404 response. When I visit the old https://github.com/padrino/padrino-static/raw/master/js/dojo.js it seems to work...

@elmer

This comment has been minimized.

Show comment
Hide comment
@elmer

elmer Oct 13, 2011

Contributor

Isn't github be swithing urls as on their blog?

try it on the console , $ curl -i https://github.com/padrino/padrino-static/raw/master/js/dojo.js

Contributor

elmer commented Oct 13, 2011

Isn't github be swithing urls as on their blog?

try it on the console , $ curl -i https://github.com/padrino/padrino-static/raw/master/js/dojo.js

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena
Member

nesquena commented Oct 13, 2011

You are right, the new url is:

https://raw.github.com/padrino/padrino-static/master/js/dojo.js

vs here's whats in the pull:

https://raw.github.com/padrino/padrino-static/raw/master/js/dojo.js

Ah look like you fixed it.

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Oct 13, 2011

Member

Looks good now, thanks.

Member

nesquena commented Oct 13, 2011

Looks good now, thanks.

nesquena added a commit that referenced this pull request Oct 13, 2011

@nesquena nesquena merged commit 08fc29a into padrino:master Oct 13, 2011

@elmer

This comment has been minimized.

Show comment
Hide comment
@elmer

elmer Oct 13, 2011

Contributor

also, are the static resources not included on the gems for offline operations?
Thanks

Contributor

elmer commented Oct 13, 2011

also, are the static resources not included on the gems for offline operations?
Thanks

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Oct 13, 2011

Member

That was a mistake on my part which is going to be corrected in a quiet release that contains this change and reincludes static assets. I am also going to add a check that ensures static assets exist from here on out.

Member

nesquena commented Oct 13, 2011

That was a mistake on my part which is going to be corrected in a quiet release that contains this change and reincludes static assets. I am also going to add a check that ensures static assets exist from here on out.

@elmer

This comment has been minimized.

Show comment
Hide comment
@elmer

elmer Oct 13, 2011

Contributor

great. thanks

Contributor

elmer commented Oct 13, 2011

great. thanks

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Oct 13, 2011

Member

Ok new version should be release 0.10.5 with your fix and static assets re-included. Can you confirm?

Member

nesquena commented Oct 13, 2011

Ok new version should be release 0.10.5 with your fix and static assets re-included. Can you confirm?

@elmer

This comment has been minimized.

Show comment
Hide comment
@elmer

elmer Oct 13, 2011

Contributor

it works if the static assets are included, which means the get('https://raw.. fails due to SSL verification error on thor's get

Contributor

elmer commented Oct 13, 2011

it works if the static assets are included, which means the get('https://raw.. fails due to SSL verification error on thor's get

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Oct 13, 2011

Member

Why do you think there's ssl fails on the get?

Member

nesquena commented Oct 13, 2011

Why do you think there's ssl fails on the get?

@elmer

This comment has been minimized.

Show comment
Hide comment
@elmer

elmer Oct 13, 2011

Contributor

appears to be a open-uri issue as thor uses it. adding these lines

require 'openssl'
OpenSSL::SSL::VERIFY_PEER = OpenSSL::SSL::VERIFY_NONE

on padrino-gen/generators/cli will fix it. Thou I am not sure if this is the correct way

Contributor

elmer commented Oct 13, 2011

appears to be a open-uri issue as thor uses it. adding these lines

require 'openssl'
OpenSSL::SSL::VERIFY_PEER = OpenSSL::SSL::VERIFY_NONE

on padrino-gen/generators/cli will fix it. Thou I am not sure if this is the correct way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment