New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set PADRINO_LOG_LEVEL constant by default #720

Merged
merged 1 commit into from Nov 22, 2011

Conversation

Projects
None yet
2 participants
@marcosdsanchez
Contributor

marcosdsanchez commented Nov 14, 2011

This PR comes after this question:
http://stackoverflow.com/questions/8082848/how-do-i-log-queries-in-a-rake-task-using-datamapper-and-padrino

Basically, I didn't understand why logging was working ok inside the padrino admin but not in a rake file.

I think the PADRINO_LOG_LEVEL constant should be included by default to make it easier to avoid problems like this.

DAddYE added a commit that referenced this pull request Nov 22, 2011

Merge pull request #720 from marcosdsanchez/padrino-logger-config
set PADRINO_LOG_LEVEL constant by default

@DAddYE DAddYE merged commit 2a02360 into padrino:master Nov 22, 2011

@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Nov 22, 2011

Member

Thanks, I think we should comment it so can be easily to uncomment when necessary.

Member

DAddYE commented Nov 22, 2011

Thanks, I think we should comment it so can be easily to uncomment when necessary.

modeverv pushed a commit to modeverv/padrino-framework that referenced this pull request Nov 23, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment