Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Add Breadcrumbs #723

Closed
wants to merge 191 commits into from

21 participants

Carlo Bertini Davide D'Agostino Nathan Esquenazi David Cuadrado Benjamin Bloch vlad Arthur Chiu Jesse Farmer Alexandros Giouzenis Joel Cuevas Michael Papile Yuya Takeyama Robert Schulze Florian Gilcher rameshpy whitequark Martin Frost Trevor Wennblom Joshua Hull Nat Welch JasonM23
Carlo Bertini

in my case i've add into controller:

before do
     @breadcrumbs ||= Padrino::Helpers::Breadcrumb.new
     @breadcrumbs.add :foo,"foo","Foo link"
end

into view:

  == breadcrumb @breadcrumbs, true

the output is

<ul class="breadcrumb">
  <li><a href="/">Home Page</a><span class="divider">></span></li>
  <li class="active"><a href="foo">Foo link</a></li>
</ul>
WaYdotNET and others added some commits
Carlo Bertini WaYdotNET add Bootstrap from Twitter 3c2f629
Carlo Bertini WaYdotNET remove xlarge and add span5 499f181
Carlo Bertini WaYdotNET form builder check_box: create hidden value with uncheck_value only if
uncheck_value exist
07e5aa1
Carlo Bertini WaYdotNET remove puts sorry :P a05748d
Carlo Bertini WaYdotNET fix a8adddf
Davide D'Agostino DAddYE New admin based on bootstrap.
Thanks to @waydotnet.

As requested in issue #568

We added:

* Twitter Bootstrap Support
* Table search
* Table sorting
* Table pagination

Still pending:

* Add Close button flash notices.

Fix #708
2b437f3
Davide D'Agostino DAddYE Improved new admin with:
* Close buttons for flashes
* Modal dialogs for `error_messages_for`
f98ee9d
Carlo Bertini WaYdotNET Merge remote-tracking branch 'upstream/master'
* upstream/master:
  Revert "[padrino-core] to_s route paths before joining"
  Added Mac DS_Store file
  README to be changed once project is generated
  [padrino-core] to_s route paths before joining
  add regexp route generation
dc6a3be
Carlo Bertini WaYdotNET Merge remote-tracking branch 'upstream/bootstrap'
* upstream/bootstrap:
  Improved new admin with:
  New admin based on bootstrap.
967cf76
DAddYE and others added some commits
Davide D'Agostino DAddYE Added missing modal as mentioned in #568. f0a2d0c
Davide D'Agostino DAddYE Ruby Style. 4b2e42c
vlad sumskyi Wrong insertion into Gemfile fixed, like:
gem 'bcrypt-ruby', require => 'bcrypt' (should be :require)
24e1bf9
Carlo Bertini WaYdotNET Merge remote-tracking branch 'upstream/bootstrap'
* upstream/bootstrap:
  Ruby Style.
  Added missing modal as mentioned in #568.
0ed4ff7
Carlo Bertini WaYdotNET Revert 0ed4ff7^..HEAD a6c4f2f
vlad sumskyi broken markup fix (FF) 5de461b
Arthur Chiu achiu Merge pull request #712 from sumskyi/bootstrap
insert_into_gemfile() fix
4712712
Carlo Bertini WaYdotNET Merge remote-tracking branch 'upstream/bootstrap'
* upstream/bootstrap:
  broken markup fix (FF)
  Wrong insertion into Gemfile fixed, like: gem 'bcrypt-ruby', require => 'bcrypt' (should be :require)
8d66652
Carlo Bertini WaYdotNET add slim support change flash style into "index" page c68c6df
Carlo Bertini WaYdotNET after create model, render index page and not edit page eebb5ab
Carlo Bertini WaYdotNET fix redirect after add new model 6cf5cc3
Carlo Bertini WaYdotNET modify redirect after update 589548f
Davide D'Agostino DAddYE Merge branch 'master' of github.com:padrino/padrino-framework into bo…
…otstrap
fb715cf
Davide D'Agostino DAddYE Merge branch 'bootstrap' of github.com:padrino/padrino-framework into…
… bootstrap
5b227cd
Davide D'Agostino DAddYE Merge branch 'master' into bootstrap
Conflicts:
	padrino-gen/lib/padrino-gen/generators/project.rb
19ddeab
Carlo Bertini WaYdotNET add save_and_continue button
Add save_and_continue button….pls check language translate :D:D:D
7208db8
Carlo Bertini WaYdotNET fix save_and_continue 6882dec
Carlo Bertini WaYdotNET refactor code
tanks @daddye
01431fd
Davide D'Agostino DAddYE Merge pull request #713 from WaYdotNET/master
add slim and save_and_continue button
8c90f03
Davide D'Agostino DAddYE Merge branch 'master' of github.com:padrino/padrino-framework into bo…
…otstrap
4f73e31
Davide D'Agostino DAddYE Merge branch 'bootstrap' of github.com:padrino/padrino-framework into…
… bootstrap
3664990
Davide D'Agostino DAddYE Removed and unused asset. 56c9be0
Davide D'Agostino DAddYE Some new enhancement to the new padrino-admin. 629320c
Davide D'Agostino DAddYE Merge branch 'master' of github.com:padrino/padrino-framework into bo…
…otstrap
e769e66
Davide D'Agostino
Owner

Have you some screenshot?

Davide D'Agostino
Owner
Carlo Bertini

hahahahahahahahh :D:D:D:D:D
sorry daddye...today reup new version into heroku :P hahahahahahah

Carlo Bertini

EDIT: change host !! (DH down )

http://glowing-leaf-7114.heroku.com/admin/
user: test@padrinorb.com pass: test

upgrade to TwB 2.0 wip ..
I hope it is useful

please check if work well :D:D:D

WaYdotNET and others added some commits
Carlo Bertini WaYdotNET upgrade to Twitter Bootstrap v 2.0 3632728
Carlo Bertini WaYdotNET upgrade slim template (work with twitter bootsrap 2.0) 28933f4
Carlo Bertini WaYdotNET fix padrino-modal f4c575c
Carlo Bertini WaYdotNET sync to master 56381e2
Carlo Bertini WaYdotNET refix padrino-modal e0b4642
Carlo Bertini WaYdotNET Merge branch 'refs/heads/original'
* refs/heads/original:
  Bundle update.
  Redis Server is already here.
  Forgot sudo. (Travis)
  Improve Travis support.
  Fix #768
  Bump to prerelease 0.10.6.c
  Fixes type, thanks @ujifgc
  Add stylesheet initializers change to changelog
  Assets from an absolute paths no longer have asset stamps appended
  Updated stylesheets initializers to respect spaces.
fbb10e7
Carlo Bertini WaYdotNET padrino-admin now work also with haml :D (yheaa!!!) 208696a
Carlo Bertini WaYdotNET update readme 0352d62
Carlo Bertini WaYdotNET add image and link to demo e45efc5
Carlo Bertini WaYdotNET Merge remote-tracking branch 'refs/remotes/padrino/master'
* refs/remotes/padrino/master:
  Travis rbx-19mode
71c6abe
Davide D'Agostino DAddYE Remove rbx from travis. No way to compile bcrypt-ruby. d980b11
jfcixmedia Fix model_attribute_translate example afcd5b4
Nathan Esquenazi nesquena Merge pull request #781 from jfcixmedia/master
Documentation for i18n translation helpers
cdbb7cb
Jesse Farmer jfarmer [Fix #784] ActiveRecord rake file should not prompt the user to log i…
…n as root if database authentication fails
5c40be1
Jesse Farmer jfarmer Rescue from StandardError vs. Exception, and print out error messages…
… to STDERR in a consistent format
48050b9
Jesse Farmer jfarmer Include timestampe by default in ActiveRecord 88bdf59
Jesse Farmer jfarmer This is ugly, but use ActiveRecord::Migration#change if we can 9a3a32a
Alexandros Giouzenis agios Allow nested hash hierarchies for "data" option
e.g. :data => {:dojo => {:type => xxx, :props => yyy}}
25eb60d
Joel Cuevas joelcuevas Fix #780 - Admin generator is not completely aware of the user define…
…d model name
61e54e8
Davide D'Agostino DAddYE Merge pull request #788 from joelcuevas/master
Fixes #780 - Admin generator is not completely aware of the user defined model name.
670f8ea
Joel Cuevas joelcuevas Still trying to fix #780. Some templates wasn't aware of a custom mod…
…el name.
417467b
Michael Papile papile Update padrino-cache/lib/padrino-cache/helpers/fragment.rb 90e0504
Davide D'Agostino DAddYE Merge pull request #789 from papile/master
Fragment caching currently disregards block content when caching is turned off
f733fce
Davide D'Agostino DAddYE Merge pull request #785 from jfarmer/master
[Fix #784] ActiveRecord rake file should not prompt the user to log in as root if database authentication fails
f208a8e
Davide D'Agostino DAddYE Drop support for old ActiveRecord Migration Syntax. d1021b4
Carlo Bertini Merge remote-tracking branch 'upstream/master' d53ef16
Carlo Bertini WaYdotNET update to twitter 2.0.2-wip e86b336
David Genord II Correctly report the loaded console environment when set via environm…
…ent variables
c28ef48
Davide D'Agostino DAddYE Merge pull request #791 from xspond/correct-console-env
Correctly report the loaded console environment when set via environment variables
43c52fe
Davide D'Agostino DAddYE Fast development mode 4a09c0e
Davide D'Agostino DAddYE Add correclty ActiveRecord Middleware. Fix #792 84f050f
Davide D'Agostino DAddYE Fix travis. b6d9ee9
Nathan Esquenazi

Shouldn't this only happen if 'activerecord' is being used for admin??

Nathan Esquenazi

Shouldn't this use the activerecord? method you defined below?

Owner

It's for future use, the orm class will be created from padrino_page in this line is only a symbol.

Owner

Ah ok

Benjamin Bloch

@DAddYE

Why was this reverted?

The current HTML 5 specification allows both forms of tags and is backwards compatible with existing XHTML. The only difference here is that those using old XHTML doctypes will have "invalid" HTML. Despite of this every web browser should accurately the page.

Additionally everything outside of ERB will automatically close your tags based on your provided doctype.

WaYdotNET and others added some commits
Carlo Bertini WaYdotNET Merge remote-tracking branch 'upstream/master' 683e46c
Yuya Takeyama yuya-takeyama Fix model directory specification for mongoid tasks. 8d2b6b9
Davide D'Agostino DAddYE Merge pull request #795 from yuya-takeyama/fix-rake-mi-create-indexes
Mongoid tasks not work
711bb69
Carlo Bertini WaYdotNET Merge remote-tracking branch 'upstream/master' 4fa32e8
David Cuadrado dcu Fix some remaining issues when generating an admin app using a custom…
… model

Signed-off-by: David A. Cuadrado <krawek@gmail.com>
0dbf8b5
Davide D'Agostino DAddYE Merge pull request #794 from dcu/master
Fix some remaining issues when generating an admin app using a custom model
be5759e
Carlo Bertini WaYdotNET merge with upstream/master ae66b5f
Carlo Bertini WaYdotNET fix missing clean code 073a02d
Carlo Bertini WaYdotNET fix d93c018
Benjamin Bloch Properly detect Windows based hosts for ansi coloring 9eb705a
Nathan Esquenazi nesquena Merge pull request #797 from Cirex/master
Detecting Windows based hosts for ansi coloring
a35faf0
Carlo Bertini WaYdotNET Merge remote-tracking branch 'upstream/master' 133087d
Carlo Bertini WaYdotNET add Icon's Bootstrap helper c8da645
Carlo Bertini WaYdotNET fix Icon's Bootstrap helper f6eca80
Carlo Bertini WaYdotNET add icon into navbar form 9205c5c
Carlo Bertini WaYdotNET remove default icon 51d507f
Alexandros Giouzenis agios Added test for nested data attributes 21312fe
Alexandros Giouzenis agios Merge remote-tracking branch 'upstream/master'
Conflicts:
	padrino-helpers/test/test_tag_helpers.rb
d2de420
Alexandros Giouzenis agios Added necessary requires 106880a
Alexandros Giouzenis agios Continue running tests if one fails df93b9b
Alexandros Giouzenis agios Added nested data attributes test b427f2f
Robert Schulze fnordfish Fixes a random error, where 'Less::Parser' was scoped as 'Less::Parse…
…r::Less::Parser'.
5be90e2
Florian Gilcher skade Merge pull request #800 from fnordfish/patch-1
Fixes a random error, where 'Less::Parser' was scoped wrongly...
ef48063
Robert Schulze fnordfish write cached css files into the default destination for public styles…
…heets
c81b095
Nathan Esquenazi nesquena Merge pull request #801 from fnordfish/master
write cached css files into the default destination for public stylesheets
1a6c9e5
Carlo Bertini WaYdotNET Merge remote-tracking branch 'upstream/master' 8fd056e
Carlo Bertini WaYdotNET Update README.rdoc 0f59583
Carlo Bertini WaYdotNET Update README.rdoc 4f237ca
Davide D'Agostino DAddYE Lumberjack Compat. Fixes #799 16fa20f
Davide D'Agostino DAddYE Fix some reloader issues. Mentioned here #786 7844404
Davide D'Agostino DAddYE Merge pull request #787 from agios/master
Allow nested hashes for "data" property in tag helper
8173344
Davide D'Agostino DAddYE Cleanup nested attributes. a7af2e0
Davide D'Agostino DAddYE Make 'data' attributes also available in all tags. d0845dc
Davide D'Agostino DAddYE Remove 'data-method' from `form_tag` since the hidden_field :_method
already override it.
9c8deed
Davide D'Agostino DAddYE Fix previous commit. 30e789e
Carlo Bertini WaYdotNET Merge remote-tracking branch 'upstream/master' 698ef90
Carlo Bertini WaYdotNET Merge branch 'master' of github.com:WaYdotNET/padrino-framework 9c4df04
Robert Schulze fnordfish Fixes a SyntaxError. 2fdca28
Carlo Bertini WaYdotNET Merge pull request #2 from fnordfish/patch-2
SyntaxError in admin's application layout
9f6ed22
Robert Schulze fnordfish removes css class "center-block", which is a less mixin, not a real c…
…ss class and thus has no effect.

corrects nesting of footer paragraphs which lead to invalid mark generation
9e03819
Carlo Bertini WaYdotNET Merge pull request #3 from fnordfish/patch-3
admin's haml footer generates invalid markup
44dce81
Carlo Bertini WaYdotNET Update to TwitterBootstrap 2.0.2 a07f9f1
Carlo Bertini WaYdotNET real update to TwitterBootstrap 2.0.2, sorry :P 65e1d51
Nathan Esquenazi nesquena Update changelog 3b18cae
Nathan Esquenazi nesquena Bumped version to 0.10.6 d5f0e2a
Nathan Esquenazi nesquena Update changelog e650330
Carlo Bertini WaYdotNET Merge remote-tracking branch 'upstream/master' da489f0
Carlo Bertini WaYdotNET fix lessjs library into session/new 6591c76
Davide D'Agostino DAddYE Propose a new fix for #807 and #808 5c2623e
Carlo Bertini WaYdotNET Merge remote-tracking branch 'upstream/master' 601f225
David Cuadrado

I don't think this will work, it's just calling .to_s

what I think we should do is create an alias before requiring external dependiencies, something like

class Class
    alias :orig_to_s :name
end

and use that instead. and btw is "name" method is more likely to be monkey patched by external libs.

EDIT: it's very easy to prove my point

ruby-1.9.3-p0 :003 > class A; def self.to_s; 'failed'; end; end
 => nil 
ruby-1.9.3-p0 :004 > A.to_s
 => "failed" 
ruby-1.9.3-p0 :005 > A.name
 => "A" 
ruby-1.9.3-p0 :006 > "#{A}"
 => "failed" 

I just made a push with what I said. please review it

Owner

For reference, https://github.com/padrino/padrino-framework/pull/807/files is his pull request. Thanks @dcu

DAddYE and others added some commits
Davide D'Agostino DAddYE Added a failing test for our routing system. 41ac060
Carlo Bertini WaYdotNET Merge remote-tracking branch 'upstream/master' e1619a8
rameshpy rameshpy Added support for activerecord-jdbcmysql-adapter for ActiveRecord tasks
ar:create, ar:drop and few others did not work with activerecord-jdbcmysql-adapter when using jruby
c22420c
Nathan Esquenazi nesquena Merge pull request #813 from rameshpy/master
activerecord-jdbcmysql-adapter tasks support
8b02ada
Carlo Bertini WaYdotNET Merge remote-tracking branch 'upstream/master' cf3aab5
whitequark whitequark Fix options_for_select result in a corner case. caf5492
Davide D'Agostino DAddYE Merge pull request #814 from whitequark/master
Fix options_for_select form helper result in a corner case.
40e0ecc
Carlo Bertini WaYdotNET Merge remote-tracking branch 'upstream/master' f039adc
Martin Frost Frost Typo in documentation: `"Appliocation" -> "Application"` 0b52251
Florian Gilcher skade Merge pull request #825 from Frost/patch-1
Typo in documentation: `"Appliocation" -> "Application"`
3e0af28
Nathan Esquenazi nesquena Use _orig_klass_name in reloader to fix pry / jruby 865d67c
Carlo Bertini WaYdotNET Merge remote-tracking branch 'upstream/master' 8bf5122
Trevor Wennblom trevor remove tlsmail dependency - already in mail gem
mail >= 2.3.0 has:
  gem "tlsmail" if RUBY_VERSION <= '1.8.6'
165743e
Joshua Hull joshbuddy Merge pull request #828 from trevor/patch-1
remove tlsmail dependency - already in mail gem
c079e1a
Simon COURTOIS Adding an options attribute to ProjectModule 35844fc
Carlo Bertini WaYdotNET Merge remote-tracking branch 'upstream/master' 0c5cb06
Nat Welch icco Adds a catch all method to the redis cache. a7a21c3
Davide D'Agostino DAddYE Merge pull request #832 from joelcuevas/master
Fix #780. Found that some templates wasn't aware of the user-defined model name in admin generator.
50b3f9b
Davide D'Agostino DAddYE Clean and test code. Fix #780 issue. 3f7081d
Carlo Bertini WaYdotNET Merge remote-tracking branch 'upstream/master' cfd9e46
Nathan Esquenazi nesquena [handler] Fixes slim handler capturing 8b79d57
Nathan Esquenazi nesquena Adds back test for slim for link_to 8a670de
Davide D'Agostino DAddYE Merge pull request #829 from simonc/adding-options-to-project-module
Adding an options attribute to ProjectModule
fd716cb
Nathan Esquenazi nesquena Update changelog with new additions 08a77a5
Carlo Bertini WaYdotNET Merge remote-tracking branch 'upstream/master' f5f7556
Carlo Bertini WaYdotNET fix identation 02e2430
Carlo Bertini WaYdotNET fix haml ef52c11
Carlo Bertini WaYdotNET update to Twitter Bootstrap 2.0.3 b98a5d2
Carlo Bertini WaYdotNET Update readme 4d32797
Carlo Bertini WaYdotNET remove Improve slim template block capturing fix #777 82a8253
Carlo Bertini WaYdotNET fix icons path b9a1e5d
Nat Welch icco Passes function calls along as suggested in #836 168f1c2
Nat Welch icco Merge branch 'master' of git://github.com/padrino/padrino-framework i…
…nto redis-extension
910ab1b
Nat Welch icco Adds a test for the new method_missing function in redis. 15cd12d
Nat Welch icco Actually passes a method name into respond_to? 459c73c
Nat Welch icco Changes the method declaration to be a little more specific. 54409cc
JasonM23 jasonm23 Patched to fix rake use in padrino templates. aac2135
Davide D'Agostino DAddYE Merge pull request #841 from jasonm23/patch-1
Patched to fix rake use in padrino templates.
9e34b16
Carlo Bertini WaYdotNET Merge remote-tracking branch 'upstream/master' 4039f3b
Davide D'Agostino DAddYE Merge pull request #836 from icco/redis-extension
Expand Padrino::Cache to support all features of underlying cache
7832933
Carlo Bertini WaYdotNET Merge remote-tracking branch 'upstream/master' 968b485
Carlo Bertini WaYdotNET fix login demo :D 01b0a94
Carlo Bertini WaYdotNET Fixes admin generator #846 68e901d
Carlo Bertini WaYdotNET Merge branch 'master' of github.com:WaYdotNET/padrino-framework 2b8467a
Carlo Bertini WaYdotNET clean code for twbootstrap fa4bec5
aereal Make mysql2 a alias of mysql when DataMapper is selected
DataMapper has `do_mysql' that is the version of MySQL driver.
So `mysql2' should be considered as a alias of `mysql' adapter.
61753fa
Nathan Esquenazi nesquena Merge pull request #856 from aereal/fix/datamapper-mysql2
Make mysql2 a alias of mysql when DataMapper is selected
41d67ef
Carlo Bertini WaYdotNET Merge remote-tracking branch 'upstream/master' 77d9b3b
Davide D'Agostino DAddYE closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.