New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nested hashes for "data" property in tag helper #787

Merged
merged 6 commits into from Mar 12, 2012

Conversation

Projects
None yet
2 participants
@agios
Contributor

agios commented Feb 14, 2012

e.g. :data => {:dojo => {:type => xxx, :props => yyy}}

Allow nested hash hierarchies for "data" option
e.g. :data => {:dojo => {:type => xxx, :props => yyy}}
@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Feb 16, 2012

Member

Can you add some test?

Thank you man!

Member

DAddYE commented Feb 16, 2012

Can you add some test?

Thank you man!

@agios

This comment has been minimized.

Show comment
Hide comment
@agios

agios Mar 7, 2012

Contributor

Tests added, sorry I could not get around it sooner

Contributor

agios commented Mar 7, 2012

Tests added, sorry I could not get around it sooner

@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Mar 12, 2012

Member

@nesquena can you review this and merge for 10.6?

Member

DAddYE commented Mar 12, 2012

@nesquena can you review this and merge for 10.6?

DAddYE added a commit that referenced this pull request Mar 12, 2012

Merge pull request #787 from agios/master
Allow nested hashes for "data" property in tag helper

@DAddYE DAddYE merged commit 8173344 into padrino:master Mar 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment