fix reloader issue with some gems that redefine Class#name (like pry) #807

Closed
wants to merge 2 commits into
from

5 participants

@dcu

padrino start doesn't work when using 'pry'

@dcu dcu fix reloader issue with some gems that redefine Class#name (like pry)
Signed-off-by: David A. Cuadrado <krawek@gmail.com>
9e7b99b
@DAddYE
Padrino Framework member

Yep, we reverted back to name because some libs redefine also to_s ... so suggestions?

@DAddYE DAddYE added a commit that referenced this pull request Mar 18, 2012
@DAddYE DAddYE Propose a new fix for #807 and #808 5c2623e
@dcu dcu make sure we can always use the original class name
Signed-off-by: David A. Cuadrado <krawek@gmail.com>
7b38e26
@nesquena
Padrino Framework member

@DAddYE Should we still merge this or is the commit you put in fix it as well?

@dcu
dcu commented Apr 4, 2012

this issue is critic... you should release a version to fix this as soon as possible.

@nesquena
Padrino Framework member

@dcu Does our version solve it 5c2623e or do we still need this?

@dcu
dcu commented Apr 4, 2012

according to @DAddYE it was .to_s before changing it to .name. his change only reverts back to the original(to_s) behaviour which, I understand, doesn't work because some libs override Class|Module#to_s
I think I explain well in the commit comments why that change won't work

my commit guarantees that it will always work in all cases

@nesquena
Padrino Framework member

OK, let's just apply your change. Does that work @DAddYE

@nesquena
Padrino Framework member

OK, well I applied your version here: 865d67c. Does that look OK @dcu? Thanks for your help in all this. I plan to release a new version soon.

@nesquena nesquena closed this Apr 5, 2012
@dcu
dcu commented Jun 8, 2012

you should start doing faster release cycles. if you don't want to do a 0.10.7 why dont you release 0.10.6.1 ?

@nesquena
Padrino Framework member

@daddye What do you think? Perhaps we should release either what we have as 0.10.7 or do as dcu suggests and just push a 0.10.6.1 at least?

@DAddYE
Padrino Framework member

I agree we can release 0.10.7

@exolab

When is the release due?

@DAddYE
Padrino Framework member

We are waiting @nesquena and @achiu confirmations

@argent-smith

C'mon guys! You can!

@nesquena
Padrino Framework member

@argent-smith Yay we can and we have, pushed 0.10.7 finally. Sorry everyone for the delays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment