Support for HTML5 time tag #816

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

Cirex commented Mar 29, 2012

If this is an acceptable patch I will write tests for it when I can. You can find additional examples in the Yard comments

en:
  time:
    formats:
      full: '%B %d, %Y @ %I:%M:%S %p'
time_tag(pull_request.created_at, :format => :full)

Would output:

<time datetime="2012-03-29T01:12:01Z">
  March 29, 2012 @ 01:12:01 AM
</time>
Owner

DAddYE commented Apr 9, 2012

Thanks! @nesquena ?

Owner

nesquena commented Apr 9, 2012

Yep I will take a look

Owner

nesquena commented Apr 27, 2012

@Cirex I like this and would like support for it but can you add a test or two and I will merge it in.

Owner

DAddYE commented Jun 11, 2012

@Cirex please add one or more tests so we can merge it. Thank you man!

+ # # => 28 Mar 14:02
+ # # => </time>
+ #
+ # time_tag(comment.created_at, 'Less then a minute ago')
@marcosdsanchez

marcosdsanchez Jun 24, 2012

Contributor

"Less then ... " should instead be "Less than..."

Owner

DAddYE commented Jun 30, 2012

@Cirex test please ;)

Owner

DAddYE commented Jul 4, 2012

Request a pull request after test. Thanks so much @Cirex

@DAddYE DAddYE closed this Jul 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment