Skip to content

optimize reloader #864

Merged
merged 2 commits into from Jul 4, 2012

3 participants

@dcu
dcu commented Jun 20, 2012

can you have a look at this code? no tests were broken and it's way faster. more than 3x faster in some of my tests

@DAddYE
Padrino Framework member
DAddYE commented Jun 20, 2012

Love it, I will try to test it tomorrow and let's you know if we can merge it in next release or so.

Thanks!

@nesquena thoughts?

@nesquena
Padrino Framework member

@DAddYE Let's test this and release as part of 0.10.8 if it works alright, want to get 0.10.7 out today.

@DAddYE
Padrino Framework member
DAddYE commented Jun 20, 2012

Perfect!

@DAddYE
Padrino Framework member
DAddYE commented Jul 4, 2012

@dcu can you add some test/specs ? Thanks!

@dcu
dcu commented Jul 4, 2012

sure, I am going to add some tests for the ObjectSpace patches since the reloader changes are just optimizations(I didn't change the behaviour) that are already covered by test_reloader_(simple|complex).rb.

@dcu dcu Refactor ObjectSpace patch to DRY it up.
Also, Added unit tests for ObjectSpace patch.
And added some debugging statements using logger.devel
d9ab016
@dcu
dcu commented Jul 4, 2012

I refactored my code a bit to avoid having the @snapshot object in memory and added the tests. the previous commit was removed

@DAddYE DAddYE merged commit 7987746 into padrino:master Jul 4, 2012
@DAddYE
Padrino Framework member
DAddYE commented Jul 4, 2012

Thanks man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.