New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

padrino-flash into padrino-core #904

Merged
merged 1 commit into from Aug 8, 2012

Conversation

Projects
None yet
3 participants
@ghost

ghost commented Aug 8, 2012

here it is ...

DAddYE added a commit that referenced this pull request Aug 8, 2012

Merge pull request #904 from lenzcom/master
padrino-flash into padrino-core

@DAddYE DAddYE merged commit 56512b5 into padrino:master Aug 8, 2012

@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Aug 8, 2012

Member

Good work @lenzcom ! Can you add some tests? Thanks!

Member

DAddYE commented Aug 8, 2012

Good work @lenzcom ! Can you add some tests? Thanks!

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Aug 8, 2012

Member

Yes, this is a lot of extra code to introduce into Padrino without any tests...we should add tests for this or revert back to using sinatra-flash.

What was lacking in sinatra-flash anyhow? What prompted you to replace it @lenzcom

Member

nesquena commented Aug 8, 2012

Yes, this is a lot of extra code to introduce into Padrino without any tests...we should add tests for this or revert back to using sinatra-flash.

What was lacking in sinatra-flash anyhow? What prompted you to replace it @lenzcom

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 8, 2012

the todo annotation and deprecation notice was the first that let me recognize.

Then, while working with the bootstrap branch and WayDotNets update to version 2 of bootstrap I began to include it as submodule into my generated projects. That worked perfectly without to make any big changes to generators and stuff.

ghost commented Aug 8, 2012

the todo annotation and deprecation notice was the first that let me recognize.

Then, while working with the bootstrap branch and WayDotNets update to version 2 of bootstrap I began to include it as submodule into my generated projects. That worked perfectly without to make any big changes to generators and stuff.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 8, 2012

@DAddYE I'm going to begin write some test code in just a sec, but be forwarned. I'm not a pro in writing tests.

ghost commented Aug 8, 2012

@DAddYE I'm going to begin write some test code in just a sec, but be forwarned. I'm not a pro in writing tests.

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Aug 8, 2012

Member

Seems like there are some existing tests here @Cirex https://github.com/Cirex/padrino-flash/tree/master/spec and that project is pretty good. Why don't we just add padrino-flash to the Gemfile then for now rather than pull in all this code and duplicate the effort?

Or I guess we can rewrite the tests that he had in his project? or we could fork the Cirex project and make it officially maintained in the padrino repo? Thoughts @DAddYE?

Member

nesquena commented Aug 8, 2012

Seems like there are some existing tests here @Cirex https://github.com/Cirex/padrino-flash/tree/master/spec and that project is pretty good. Why don't we just add padrino-flash to the Gemfile then for now rather than pull in all this code and duplicate the effort?

Or I guess we can rewrite the tests that he had in his project? or we could fork the Cirex project and make it officially maintained in the padrino repo? Thoughts @DAddYE?

@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Aug 8, 2012

Member

I prefer to manage it directly because I got always problems with these flash helpers maybe abbandonware like rack-flash.

Member

DAddYE commented Aug 8, 2012

I prefer to manage it directly because I got always problems with these flash helpers maybe abbandonware like rack-flash.

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Aug 8, 2012

Member

Ok that makes sense then

Member

nesquena commented Aug 8, 2012

Ok that makes sense then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment