New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support keys as symbols when expiring cache #947

Merged
merged 1 commit into from Oct 22, 2012

Conversation

Projects
None yet
2 participants
@dariocravero
Contributor

dariocravero commented Oct 22, 2012

Correct me if I'm wrong but a cached value can be set using either a String and a Symbol. In other words:

  cache(:something, 'some value')

is the same as:

  cache ('something', 'some value')

I don't know if there's a particular reason not to use Symbols but if you're trying to expire a cached value created using a Symbol key you get an error unless there's an URL on the controller that matches that key, in which case it's even worse since that's not what you're trying to achieve when deleting that key.

I'm attaching a simple patch to support both Symbols and Strings.

Let me know if it should be like that or I'm just missing something.

Thanks

Darío Javier Cravero
Support keys as symbols when expiring cache
Correct me if I'm wrong but a cached value can be set using either a String and a Symbol. In other words:

  cache(:something, 'some value')

is the same as:

  cache ('something', 'some value')

I don't know if there's a particular reason not to use Symbols but if you're trying to expire a cached value created using a Symbol key you get an error unless there's an URL on the controller that matches that key, in which case it's even worse since that's not what you're trying to achieve when deleting that key.

I'm attaching a simple patch to support both Symbols and Strings.

Let me know if it should be like that or I'm just missing something.

Thanks

DAddYE added a commit that referenced this pull request Oct 22, 2012

Merge pull request #947 from dariocravero/patch-2
Support keys as symbols when expiring cache

@DAddYE DAddYE merged commit a4ecbb1 into padrino:master Oct 22, 2012

1 check passed

default The Travis build passed
Details
@DAddYE

This comment has been minimized.

Show comment
Hide comment
@DAddYE

DAddYE Oct 22, 2012

Member

Thanks man!

Member

DAddYE commented Oct 22, 2012

Thanks man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment