Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better subdomain resolution #15

Closed
pageer opened this issue Apr 11, 2020 · 1 comment
Closed

Better subdomain resolution #15

pageer opened this issue Apr 11, 2020 · 1 comment
Assignees
Milestone

Comments

@pageer
Copy link
Owner

pageer commented Apr 11, 2020

Right now the subdomain detection logic assumes that the document root for each subdomain lives under a single directory. For example, if SUBDOMAIN_ROOT is /var/www/vhosts, then it would be assumed that foo.example.com would have it's document root at /var/www/vhosts/foo. This is obviously incorrect for many configurations and so inadequate in general.

This should be changed to allow for more configurations. This might mean turning this into an array, allowing regex or glob values, or something else.

@pageer pageer added this to the LnBlog 2.2 milestone Aug 11, 2020
@pageer pageer added this to To do in LnBlog Release Planning via automation Aug 11, 2020
@pageer pageer self-assigned this Nov 14, 2020
@pageer
Copy link
Owner Author

pageer commented Nov 14, 2020

Feature requirements and design document is available here.

pageer pushed a commit that referenced this issue Dec 12, 2020
@pageer pageer closed this as completed Dec 12, 2020
LnBlog Release Planning automation moved this from To do to Done Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant