Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto sitemap is broken for subdomains #17

Closed
pageer opened this issue Jul 4, 2020 · 1 comment
Closed

Auto sitemap is broken for subdomains #17

pageer opened this issue Jul 4, 2020 · 1 comment

Comments

@pageer
Copy link
Owner

pageer commented Jul 4, 2020

Some of the changes to the localpath-to-uri logic appear to have broken subdomains. When using the "Automatically list all blogs in sitemap" setting for the SiteMap plugin, all of the blogs that are on their own subdomain just use the current domain as their URL, rather than the correct blog subdomain.

The fix for this is probably to just do away with that function - take all the brains our of it and just make the URL a configuration setting. Maybe make the blog creation do a best-guess at the appropriate URL, but save that as a config and allow it to be manually over-ridden, then just make the config authoritative. There are just too many possibilities and too many cases that the logic gets wrong.

@pageer pageer added this to the LnBlog 2.2 milestone Aug 11, 2020
@pageer pageer added this to To do in LnBlog Release Planning via automation Aug 11, 2020
@pageer
Copy link
Owner Author

pageer commented Dec 12, 2020

This is resolved by the fix for #15.

@pageer pageer closed this as completed Dec 12, 2020
LnBlog Release Planning automation moved this from To do to Done Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant