Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize third-party JavaScript #20

Closed
pageer opened this issue Aug 11, 2020 · 1 comment
Closed

Localize third-party JavaScript #20

pageer opened this issue Aug 11, 2020 · 1 comment

Comments

@pageer
Copy link
Owner

pageer commented Aug 11, 2020

Right now, the handful of third-party JavaScript dependencies is a mish-mash of files checked into the repo and links to CDN scripts. We should manage all that properly. Make the default to pull the dependences from NPM, install them as part of the build process, and maybe make using a CDN an option you can turn on.

This will have the nice side-effect of letting us upgrade TinyMCE, which currently requires an API key if you want to use the latest version from the CDN.

@pageer pageer added this to the LnBlog 2.2 milestone Aug 11, 2020
@pageer pageer added this to To do in LnBlog Release Planning via automation Aug 11, 2020
@pageer
Copy link
Owner Author

pageer commented Sep 13, 2020

Fixed in 0379adc

@pageer pageer closed this as completed Sep 13, 2020
LnBlog Release Planning automation moved this from To do to Done Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant