Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{id} in the settings for custom blog permalinks does not work #926

Open
Torsten-K opened this issue May 7, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@Torsten-K
Copy link

commented May 7, 2019

Problem

The tag {id} in the settings for custom blog permalinks does not work. The URL (permalink) doesn’t get generated, and clicking on Read more does not open the article. All other tags, as described in the doceumentation, like {year} or {slug}, do work.

Technical Details

  • Pagekit version: 1.0.16
  • Webserver: Apache 2.4
  • Database: SQLite
  • PHP Version: 7.2
@tobbexiv

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2019

This is an issue with the blog extension.

I assume that it is caused by this line: https://github.com/pagekit/extension-blog/blob/master/src/UrlResolver.php#L96

Untested solution: Move the unset to the beginning of the method, directly after the first assignement of the id as it should be unset, but if it's part of the url also set again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.