New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console Modules/Extensions #703

Open
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
4 participants
@crwgregory
Copy link
Contributor

crwgregory commented Jul 11, 2016

This request is to allow any module with a type of 'console' to be loaded into the application before the 'console.init' event is called, but also allows for future development by adding a getType function in the module manager that returns any registered modules of a specific type.

Currently modules don't get loaded before the 'console.init' event is called and this is limiting if you want to build a pagekit extension/module that extends the pagekit console.

Adding 'getType' function to the module manager to return any registe…
…red modules by type. Getting all types of modules by 'console' in the Console Application and loading before calling 'console.init'.
@crwgregory

This comment has been minimized.

Copy link
Contributor

crwgregory commented Jul 13, 2016

An example of what kind of extension this feature would allow for:
https://github.com/drunken-kungfu/pagekit-template-generator

@gholleyd

This comment has been minimized.

Copy link

gholleyd commented Aug 2, 2016

I would like this to merged in. Something like this could be used to create a custom command running on a cron job, which could have several advantages for clearing cache, generating reports, post processing, and a bunch of other things.

@MalteScharenberg

This comment has been minimized.

Copy link
Contributor

MalteScharenberg commented Aug 3, 2016

Indeed, this can be quite useful. But it has to be secured that no extension break the console app, because the console app should also serve as a "rescue tool", if some fatal errors preventing the usage in the browser.

@crwgregory

This comment has been minimized.

Copy link
Contributor

crwgregory commented Aug 3, 2016

@MalteScharenberg How do you imagine something like that working? Could you give an example of a situation where you would need to use the console as a "rescue tool" and I can try to implement a safety mechanism into the pull request.

@SPQRInc

This comment has been minimized.

Copy link
Contributor

SPQRInc commented Jan 30, 2017

Need this feature urgently. Maybe it would be an option to start ./pagekit --safe which does not include any extensions at all - this could be used to recover a pagekit-instance in case of emergency.

@tobbexiv tobbexiv referenced this pull request Mar 27, 2017

Closed

CLI-Command #812

@SPQRInc

This comment has been minimized.

Copy link
Contributor

SPQRInc commented Dec 7, 2017

Any news on that?

@crwgregory

This comment has been minimized.

Copy link
Contributor

crwgregory commented Dec 7, 2017

I haven't worked with pagekit for over a year now. If you are wanting to implement this feature feel free to get into the pull request and add in a safety feature. Shouldn't be to hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment