add_instrumentation should respect MapRewriteDomain #465

Open
GoogleCodeExporter opened this Issue Apr 6, 2015 · 4 comments

Comments

Projects
None yet
1 participant
A user that has mod_pagespeed running behind a proxy may have a situation where 
mod_pagespeed thinks its rewriting HTML being served on HTTPS.  However a proxy 
in front of mod_pagespeed serves it as HTTPS.  We can get the resources 
rewritten properly with ModPagespeedMapRewriteDomain, however, 
add_instrumentation will still send beacons via http.

I think this is a matter of doing that mapping in add_instrumentation_filter.cc.

Original issue reported on code.google.com by jmara...@google.com on 13 Jul 2012 at 7:06

Anupama you are in the general vicinity of this one now; can you fix?

Original comment by jmara...@google.com on 12 Nov 2013 at 5:14

I will take this up. Looking at the code, I feel that critical images and 
critical css beacons should also have the same issue, correct?

Original comment by anup...@google.com on 12 Nov 2013 at 6:00

Yes I think so.

Original comment by jmara...@google.com on 12 Nov 2013 at 8:14

Original comment by anup...@google.com on 2 Apr 2014 at 1:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment