Update the BoringSSL instructions to match current paths, #1457

Merged
merged 1 commit into from Dec 20, 2016

Projects

None yet

3 participants

@morlovich
Contributor

submodule update directions (thanks to Steve to help with that!)

@morlovich morlovich Update the BoringSSL instructions to match current paths,
submodule update directions (thanks to Steve to help with that!)
b3afe79
@morlovich
Contributor

Jeff, this should re-run .gyp based on the .gypi changing automatically, right?

@morlovich morlovich requested review from jeffkaufman and hillsp Dec 20, 2016
@@ -26,6 +40,3 @@ http://googlechromereleases.blogspot.com/search/label/Stable%20updates
cp -r src/third_party/boringssl/$arch $SERF_DIR/$arch/
done
@hillsp
hillsp Dec 20, 2016 Contributor

Dunno if it's worth calling out that you need to cd back into the git directory, commit stuff and push? It's probably also a good idea to spin a build before pushing at least.

But this looks much better, thanks.

@hillsp
Contributor
hillsp commented Dec 20, 2016

On the subject of gyp, I don't think we have any automatic rules that update makefiles with the gypfiles change. One just has to re-run gyp "manually"

@jeffkaufman
Member

@morlovich wrote:

this should re-run .gyp based on the .gypi changing automatically, right?

@hillsp wrote:

I don't think we have any automatic rules that update makefiles with the gypfiles change. One just has to re-run gyp "manually"

All existing gyp(i) files are listed in mod_pagespeed/gyp_manifest.d, a temporary file that's created when you first start using devel/Makefile and loaded as GYP_FILES Then if any of those existing gyp files change that invalidates HOOKS_STAMP, making gyp rerun itself:

$(HOOKS_STAMP) : $(GPERF) $(GYP_FILES)
        bash -o pipefail -c \
          "cd $(GIT_SRC) && python build/gyp_chromium --depth=. | \              
             egrep -v '^(Generating )[a-zA-Z0-9_/.-]*(Makefile|mk)$$'"
        touch $(HOOKS_STAMP)
@jeffkaufman

LGTM

@morlovich morlovich merged commit 7639b3d into master Dec 20, 2016

2 of 3 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@morlovich morlovich deleted the morlovich-updating-boringssl-update branch Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment