Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

How to contribute? #1

Closed
zhuzhaoyuan opened this Issue Oct 11, 2012 · 10 comments

Comments

Projects
None yet
4 participants

It seems that you are looking for people who are familiar with nginx internals (http://news.ycombinator.com/item?id=4638712) We happen to have a good understanding of nginx internals (the Tengine web server is an example of this: http://tengine.taobao.org http://github.com/taobao/tengine), and we plan to implement an nginx module based on mod_pagespeed. So we're very excited to see this project started.

I think maybe we can do something together? If so, my questions are what we can help and how to contribute? Thank you very much in advance.

P.S. does it make sense to follow the coding style of nginx itself?

Contributor

yaoweibin commented Oct 11, 2012

PPS: Tengine can support dynamic library. It should be easier to work with pagespeed library.

Owner

igrigorik commented Oct 11, 2012

Awesome. Would love to get your guys input and expertise on this.

I've started a new discussion group, let's take this discussion there:
https://groups.google.com/d/topic/ngx-pagespeed-discuss/a6T3mXs2P5Y/discussion

P.S. +1 for nginx coding style.. and tengine + dynamic loading sounds really interesting.

@ghost

ghost commented Oct 12, 2012

hot detect MIME set type html/css/img ?

pagespeed on;
pagespeed_types    text/html text/css image/png image/gif
                   image/jpeg application/x-javascript;

# Filters: http://www.modpagespeed.com/
#pagespeed_filter <type> <value>;
#pagespeed_filter combine_css on;
@ghost

ghost commented Oct 12, 2012

FreeBSD patch

/etc/make.conf

nginx

.if ${.CURDIR:M/usr/ports/www/nginx}
CONFIGURE_ARGS+=--add-module=/root/nginx-module/ngx_pagespeed
.endif

nginx-devel

.if ${.CURDIR:M/usr/ports/www/nginx-devel}
CONFIGURE_ARGS+=--add-module=/root/nginx-module/ngx_pagespeed
.endif


please send request to OSA = http://www.freebsd.org/send-pr.html

Owner

igrigorik commented Oct 12, 2012

@PGBI the types should be picked up automatically by ngx_pagespeed already. Having said that, happy to discuss.. we have a new group live, please check it out and post any thoughts or recommendations:

https://groups.google.com/forum/#!forum/ngx-pagespeed-discuss

@ghost

ghost commented Oct 12, 2012

hmm.. git (module ngx_pagespeed) + svn(google library modpagespeed) merge
git + svn update only

$ svn co http://modpagespeed.googlecode.com/svn/branches/latest-beta/src /path/to/ngx_pagespeed/src
Owner

igrigorik commented Oct 12, 2012

@PGBI @mtourne's implementation was a basic prototype and never went further then that (unfortunately).

mtourne commented Oct 12, 2012

I hope that this project goes further than my proof of concept.
The core of pagespeed (look for "instaweb" in the source) seems very well designed and extensible, it would be a great addition to the Nginx ecosystem!

@ghost

ghost commented Oct 12, 2012

@igrigorik @yaoweibin

PageSpeed Optimization Libraries (psol) library bad depend, so sad

.if ${.CURDIR:M/usr/ports/www/nginx*}
CONFIGURE_ARGS+="--add-module=/root/nginx_modules/ngx_pagespeed"
.endif

cd /usr/ports/www/nginx-devel; make install clean;


===> nginx-devel-1.3.7 depends on file: /usr/local/lib/libcrypto.so.8 - found
===> nginx-devel-1.3.7 depends on shared library: pcre - found
===> Configuring for nginx-devel-1.3.7

adding module in /root/nginx_modules/ngx_pagespeed
checking for psol ... not found
./configure: error: module ngx_pagespeed requires the pagespeed optimization library
===>  Script "configure" failed unexpectedly.
Please report the problem to osa@FreeBSD.org [maintainer] and attach the
"/usr/ports/www/nginx-devel/work/nginx-1.3.7/config.log" including the output
of the failure of your make command. Also, it might be a good idea to provide
an overview of all packages installed on your system (e.g. a /usr/sbin/pkg_info
-Ea).
*** [do-configure] Error code 1
# uname -rsp
FreeBSD 9.1-PRERELEASE amd64

@yaoweibin yaoweibin pushed a commit to yaoweibin/ngx_pagespeed that referenced this issue Dec 10, 2012

@dinic dinic Merge pull request #1 from yaoweibin/junmin-ngx-url-async-fetcher
Junmin ngx url async fetcher
61ec8b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment