Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

MapProxyDomain missing support for optional rewrite_domain argument (CDN support) #183

Closed
jonathandietz opened this Issue · 2 comments

2 participants

@jonathandietz

It seems the pagespeed library being used by nginx is slightly behind the apache version.

MapProxyDomain is missing support for the optional, third argument which sets the rewrite domain. This is needed when trying to optimize resources from an external resource such as S3 and then serve them from a CDN.

More Info:
https://developers.google.com/speed/docs/mod_pagespeed/domains#MapProxyDomain

If the optional rewrite_domain/subdir argument is supplied then optimized resources will be rewritten to that location. This is useful for rewriting optimized resources proxied from an external origin to a CDN.

ModPagespeedMapProxyDomain target_domain/subdir origin_domain/subdir [rewrite_domain/subdir]

http://modpagespeed.com/psol/classnet__instaweb_1_1DomainLawyer.html#a68885ddad932612d6ae7ade2d42b639a
(shows the missing to_domain_name support)

@jeffkaufman
Owner

Yes this is missing, and yes it's because we're using an old version of the pagespeed library. Getting ngx_pagespeed onto a current pagespeed version is one of my goals for the week, which should fix this problem. I'll be sure to test that MapProxyDomain works with both two and three arguments after we update.

@jeffkaufman
Owner

The three argument (cdn supporting) version of MapProxyDomain is now in ngx_pagespeed; let me know if you run into any issues with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.