server side includes aren't handled properly #224

Closed
jeffkaufman opened this Issue Apr 4, 2013 · 1 comment

Projects

None yet

2 participants

Contributor

With:

location /mod_pagespeed_test/ssi/ {
  ssi on;

  pagespeed EnableFilters collapse_whitespace,remove_comments,combine_css;
  pagespeed DisableFilters add_instrumentation;
  pagespeed DisableFilters inline_css;
}

(See: 5c7f328)

And html:

header.html:
    <head>
    <link rel="stylesheet" type="text/css" href="/mod_pagespeed_example/styles/yellow.css">
    <link rel="stylesheet" type="text/css" href="/mod_pagespeed_example/styles/blue.css">
    <link rel="stylesheet" type="text/css" href="/mod_pagespeed_example/styles/big.css">
    <link rel="stylesheet" type="text/css" href="/mod_pagespeed_example/styles/bold.css">
    </head>

ssi.shtml:
    <!--#include virtual="/mod_pagespeed_test/ssi/header.html" -->
    <body>
    <p>Output styled via ssi include.</p>
    </body>

Then if I fetch:

 curl http://localhost:8050/mod_pagespeed_test/ssi/ssi.shtml?ModPagespeedFilters=combine_css

It hangs.

With ModPagespeed=off the server side include works properly:

curl http://localhost:8050/mod_pagespeed_test/ssi/ssi.shtml?ModPagespeed=off

With no ModPagespeedFilters or with ModPagespeedFilters=something_that_ignores_resources we return immediately with the ssi filtered out:

$ curl http://localhost:8050/mod_pagespeed_test/ssi/ssi.shtml

<head/><body>
<p>Output styled via ssi include.</p>
</body>

And the same with curl http://localhost:8050/mod_pagespeed_test/ssi/ssi.shtml?ModPagespeedFilters=remove_comments.

@oschaaf oschaaf was assigned Apr 10, 2013
Contributor

Fixed: #242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment