Port Apache-Specific System Test #40

Closed
jeffkaufman opened this Issue Nov 8, 2012 · 0 comments

Projects

None yet

1 participant

Contributor

Port apache_system_test.sh.

This actually needs to happen mostly inside google, moving as much as possible into the generic system_test to avoid massive test duplication. The problem is that right now the apache-specific system test includes things both that really are apache specific and things that are just easier to test if you assume apache. The second category is much larger, and is mostly because anything that wants to turn on an option just for one test currently can't go in the generic version.

Plan:

  • someone at google converts tests from using one large configuration file with conditionally enabled sections to using named vhosts. This lets us move to a much smaller number of test scripts.
  • someone at google moves tests that are not truly apache-specific into system_test.sh
  • someone (maybe at google) writes a configuration transformation script that takes a description of the configuration and produces apache and nginx configuration files for it.
  • then the system test should run in nginx, and we'll need some iterations to get it to pass.
@jeffkaufman jeffkaufman closed this Dec 4, 2012
@jeffkaufman jeffkaufman reopened this Dec 4, 2012
@jeffkaufman jeffkaufman pushed a commit that referenced this issue Jan 25, 2013
Jeff Kaufman experiments: support RunExperiment
Before the experiment code was just setting the need_to_store_experiment_data
option but nothing was looking at that option.  Rewrote the code, basing it on
InstawebContext::SetFuriousStateAndCookie, in order to actually set the cookie
to support the experiment.  There are tests for this functionality, but we're
waiting on issue #40 to be able to run them.

Manual testing (with line wrapping):

    $ curl -s -D- http://localhost:8050/mod_pagespeed_example/ | grep GFURIOUS
    Set-Cookie: _GFURIOUS=1; Expires=Fri, 01 Feb 2013 21:38:31 GMT;
                Domain=.localhost; Path=/

    $ curl -s -D- http://localhost:8050/mod_pagespeed_example/ | grep GFURIOUS
    Set-Cookie: _GFURIOUS=2; Expires=Fri, 01 Feb 2013 21:42:56 GMT;
                Domain=.localhost; Path=/

And it responds properly on receiving the cookie, although it did that before
this change too.
b911381
@jeffkaufman jeffkaufman pushed a commit that referenced this issue Jan 29, 2013
Jeff Kaufman experiments: support RunExperiment
Before the experiment code was just setting the need_to_store_experiment_data
option but nothing was looking at that option.  Rewrote the code, basing it on
InstawebContext::SetFuriousStateAndCookie, in order to actually set the cookie
to support the experiment.  There are tests for this functionality, but we're
waiting on issue #40 to be able to run them.

Manual testing (with line wrapping):

    $ curl -s -D- http://localhost:8050/mod_pagespeed_example/ | grep GFURIOUS
    Set-Cookie: _GFURIOUS=1; Expires=Fri, 01 Feb 2013 21:38:31 GMT;
                Domain=.localhost; Path=/

    $ curl -s -D- http://localhost:8050/mod_pagespeed_example/ | grep GFURIOUS
    Set-Cookie: _GFURIOUS=2; Expires=Fri, 01 Feb 2013 21:42:56 GMT;
                Domain=.localhost; Path=/

And it responds properly on receiving the cookie, although it did that before
this change too.
5a10e31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment