standby: add standby mode #1365
Conversation
Add standby mode for ngx_pagespeed, equivalent to "off" in mod_pagespeed. With this change "off" is deprecated, and people should use "unplugged" instead.
| // Also, "off" is deprecated and people should be using "standby" or | ||
| // "unplugged" now depending on which sense they want. See comment on | ||
| // RewriteOptions::EnabledEnum. | ||
| enabled = RewriteOptions::kEnabledUnplugged; |
There was a problem hiding this comment.
I am kinda wondering if the mod_pagespeed parser shouldn't do the same and we shouldn't kill the Off enum... Seems a little easier to think of this way, even if it would risk making some of the parsing redundant?
There was a problem hiding this comment.
That's a good idea! Let me try that.
There was a problem hiding this comment.
Getting rid of EnabledOff turns out to be pretty hard. We have a nice option parsing abstraction that isn't compatible with the idea that "off" should map to one value in one server and another value in another server. It would be possible to extend this, but I don't think it's worth it seeing as once we're done parsing the options everything just asks about enabled() and unplugged() and doesn't see the enums.
Add standby mode for ngx_pagespeed, equivalent to "off" in mod_pagespeed.
With this change "off" is deprecated, and people should use "unplugged" instead.
See also: apache/incubator-pagespeed-mod#1482
Fixes: #968