Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

system-test: infrastructure, host validation #195

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

jeffkaufman commented Mar 28, 2013

No description provided.

Owner

oschaaf commented Mar 28, 2013

This LGTM, though when I run this, I see a few lines on stderr that probably shouldn't be there:

 test/nginx_system_test.sh 8090 8091 /home/oschaaf/code/google/mod_pagespeed /tmp/ngx_pagespeed_cache /usr/local/nginx/sbin/nginx > tmp

...
/home/oschaaf/code/google/mod_pagespeed/src/install/system_test_helpers.sh: line 249: [: : integer expression expected
grep: .alt=A cup of joe.,: No such file or directory
grep: .alt=A cup of joe.,: No such file or directory
grep: .alt=A cup of joe.s ..joe...,: No such file or directory
grep: .alt=A cup of joe.s ..joe...);: No such file or directory
--2013-03-28 16:30:09--  http://localhost:8090/mod_pagespeed_example/.pagespeed.ce.8CfGBvwDhH.css
Resolving localhost (localhost)... 127.0.0.1
Connecting to localhost (localhost)|127.0.0.1|:8090... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/html]
Saving to: `/dev/null'
...

I think these come from system_test.sh, and actually have nothing to do with this pull.

Contributor

jeffkaufman commented Mar 28, 2013

Running on my box in both apache and nginx, I get the "cup of joe" lines but not the "integer expression expected" error.

I think you're right that they probably don't have to do with this pull, but they're still a bit worrisome.

@jeffkaufman jeffkaufman pushed a commit that referenced this pull request Mar 28, 2013

Jeff Kaufman system-test: infrastructure, host validation
We are going to need some nginx-specific system tests, and this seemed like a
good place to start. This adds two tests, as well as some infrastructure. With

Squash-merge of my #194 and #195
51ebf51
Contributor

jeffkaufman commented Mar 28, 2013

merged: 51ebf51

@jeffkaufman jeffkaufman deleted the jefftk-system-test-initial branch Mar 28, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment