Small fixes (#13)

* fix linting

* add docker compose dev

Dockerfile

@@ -1,7 +1,5 @@
 FROM circleci/node:10.14.2 as builder
 
-RUN sudo apt-get -y install --no-install-recommends libunwind8=1.1-4.1
-
 WORKDIR /usr/src/app
 
 COPY /src /usr/src/app/src
@@ -16,11 +14,6 @@ RUN sudo chmod -R 777 /usr/src/app \
 FROM node:10.14.2-alpine
 LABEL maintainer="https://pagopa.gov.it"
 
-# Install major CA certificates to cover
-# https://github.com/SparebankenVest/azure-key-vault-to-kubernetes integration
-RUN apk update && \
-    apk add ca-certificates
-
 WORKDIR /usr/src/app
 
 COPY /package.json /usr/src/app/package.json

docker-compose.override.dev.yml

@@ -0,0 +1,8 @@
+version: "2.2"
+
+services:
+  io-spid-commons:
+    image: node:10.14.2-alpine
+    working_dir: /usr/src/app
+    volumes:
+      - ".:/usr/src/app"

src/example.ts

@@ -55,7 +55,6 @@ const appConfig: IApplicationConfig = {
 const serviceProviderConfig: IServiceProviderConfig = {
   IDPMetadataUrl:
     "https://registry.spid.gov.it/metadata/idp/spid-entities-idps.xml",
-  spidValidatorUrl: "http://localhost:8080",
   idpMetadataRefreshIntervalMillis: 120000,
   organization: {
     URL: "https://example.com",
@@ -67,7 +66,8 @@ const serviceProviderConfig: IServiceProviderConfig = {
     attributes: ["email", "name", "familyName", "fiscalNumber", "mobilePhone"],
     name: "Required attrs"
   },
-  spidTestEnvUrl: "https://spid-testenv2:8088"
+  spidTestEnvUrl: "https://spid-testenv2:8088",
+  spidValidatorUrl: "http://localhost:8080"
 };
 
 const redisClient = redis.createClient({

src/strategy/redis_cache_provider.ts

@@ -31,15 +31,15 @@ export const overrideCacheProvider = (): CacheProvider => {
   return {
     // saves the key with the optional value
     // invokes the callback with the value saved
-    save(key, value, callback): void {
+    save(_, value, callback): void {
       const v = {
         createdAt: new Date(),
         value
       };
       callback(null, v);
     },
     // invokes 'callback' and passes the value if found, null otherwise
-    get(key, callback): void {
+    get(_, callback): void {
       callback(null, {});
     },
     // removes the key from the cache, invokes `callback` with the

src/utils/middleware.ts

@@ -32,8 +32,8 @@ export interface IServiceProviderConfig {
     name: string;
   };
   publicCert: string;
-  spidValidatorUrl: string | undefined;
   idpMetadataRefreshIntervalMillis: number;
+  spidValidatorUrl?: string;
 }
 
 export interface ISpidStrategyOptions {

src/utils/saml.ts

@@ -7,15 +7,7 @@
 import { distanceInWordsToNow, isAfter, subDays } from "date-fns";
 import { Request as ExpressRequest } from "express";
 import { difference, flatten } from "fp-ts/lib/Array";
-import {
-  Either,
-  fromOption,
-  fromPredicate,
-  isLeft,
-  left,
-  right,
-  toError
-} from "fp-ts/lib/Either";
+import { Either, fromOption, fromPredicate, toError } from "fp-ts/lib/Either";
 import { not } from "fp-ts/lib/function";
 import {
   fromEither,