Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/chat command disable #1678

Closed
wants to merge 4 commits into from

Conversation

sirinoks
Copy link

@sirinoks sirinoks commented Jan 7, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable
  • Documentation in docs/ or install-docs/ was updated, if applicable
  • I have tested all changes

Addresses
#1499
and
#838

@zneix
Copy link
Contributor

zneix commented Jan 7, 2022

Now when I look at it, we perhaps misunderstood each other - in #1499 when I said be able to disable a command from chat, without need to open dashboard I've meant: being able to disable or enable a command by typing something in chat (instead of having to go to dashboard). I didn't mean: being able to disable a command from the chat, as in being unable to use the command in chat.

@sirinoks
Copy link
Author

sirinoks commented Jan 8, 2022

Now when I look at it, we perhaps misunderstood each other - in #1499 when I said be able to disable a command from chat, without need to open dashboard I've meant: being able to disable or enable a command by typing something in chat (instead of having to go to dashboard). I didn't mean: being able to disable a command from the chat, as in being unable to use the command in chat.

Sorry, I don't really get it. Could you explain to me like I'm 5?

@ALazyMeme
Copy link
Member

I believe this was already fixed here, no?

@pajlada
Copy link
Member

pajlada commented Jan 8, 2022

#1499 was fixed by #1502 but we forgot to close the issue, sorry! See https://github.com/pajbot/pajbot/pull/1678/files#diff-422df9a79c9a27c7c20d092ff3129c46cb58785b7ef46cb72a6a89226ddd468fR456-R457 for the code, usage would be !edit command test --disable or !edit command --enable, which is what #1502 fixed.

Closing for now, feel free to re-open if you believe this serves a purpose that the original #1502 fix did not!

@pajlada pajlada closed this Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants