New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Table] Fix interaction-bar styles #1163
Conversation
Fix header menu styles when selection disabledPreview: documentation | table |
Nice stuff. In addition, can we add the "drag handle" icon to the left of the interaction bar (currently missing when both the interaction bar and reordering are enabled)? It would allow for explicit and direct single-column reordering without the need to select first: Also, unrelated to this PR but related to reordering: I just noticed it's a bit annoying to not be able to create a new column selection starting from a currently selected column 😞 This behavior is inconsistent with body cell selection at the moment. Excel avoids this problem by enabling reordering when hovering the edge of the selection region, an interaction that has its own issues too (i.e. very thin hover target). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird issue where cursor changes to grabbing
after drag is completed (or simply after a click without dragging)
@llorca can definitely address your feedback in separate PRs! This PR is just a quick patch to fix wrongness in existing behavior. |
@giladgray do my latest changes address the issues you were seeing? |
Fix grabbing style when :activePreview: documentation | table |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
Changes proposed in this pull request:
cursor: grab
when mousing over interaction bar while reordering is enabled.Reviewers should focus on:
Screenshot