Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Fix interaction-bar styles #1163

Merged
merged 4 commits into from Jun 8, 2017
Merged

Conversation

cmslewis
Copy link
Contributor

@cmslewis cmslewis commented May 31, 2017

Changes proposed in this pull request:

  • Show cursor: grab when mousing over interaction bar while reordering is enabled.
  • Fix header menu's gradient background color when selection is disabled (background gets darker on hover when selection is enabled, but the background color doesn't change on hover when selection is disabled)

Reviewers should focus on:

  • Does all the SCSS look okay?
  • Do the styles look good when:
    • selection is enabled/disabled?
    • interaction bar is enabled/disabled?

Screenshot

screen shot 2017-05-30 at 5 56 41 pm

screen shot 2017-05-30 at 5 56 48 pm

screen shot 2017-05-30 at 5 57 56 pm

screen shot 2017-05-30 at 5 58 14 pm

2017-06-01 14 21 01

@blueprint-bot
Copy link

Fix header menu styles when selection disabled

Preview: documentation | table
Coverage: core | datetime

@llorca
Copy link
Contributor

llorca commented May 31, 2017

Nice stuff. In addition, can we add the "drag handle" icon to the left of the interaction bar (currently missing when both the interaction bar and reordering are enabled)? It would allow for explicit and direct single-column reordering without the need to select first:

screen shot 2017-05-30 at 6 52 34 pm

Also, unrelated to this PR but related to reordering: I just noticed it's a bit annoying to not be able to create a new column selection starting from a currently selected column 😞 This behavior is inconsistent with body cell selection at the moment. Excel avoids this problem by enabling reordering when hovering the edge of the selection region, an interaction that has its own issues too (i.e. very thin hover target).

Copy link
Contributor

@giladgray giladgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird issue where cursor changes to grabbing after drag is completed (or simply after a click without dragging)

@giladgray
Copy link
Contributor

might be hard to grok, but here's a gif of my issue:
table-drag-grabbing

@cmslewis
Copy link
Contributor Author

cmslewis commented Jun 1, 2017

@llorca can definitely address your feedback in separate PRs! This PR is just a quick patch to fix wrongness in existing behavior.

@cmslewis
Copy link
Contributor Author

cmslewis commented Jun 1, 2017

@giladgray do my latest changes address the issues you were seeing?

@blueprint-bot
Copy link

Fix grabbing style when :active

Preview: documentation | table
Coverage: core | datetime

Copy link
Contributor

@giladgray giladgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@cmslewis cmslewis merged commit 2679c7f into master Jun 8, 2017
@cmslewis cmslewis deleted the cl/table-interaction-bar-styles branch June 8, 2017 20:17
@giladgray giladgray mentioned this pull request Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants