Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Always disable batch-rendering in headers #1679

Merged
merged 2 commits into from Oct 6, 2017

Conversation

cmslewis
Copy link
Contributor

@cmslewis cmslewis commented Oct 6, 2017

Changes proposed in this pull request:

  • 馃攧 CHANGED Table now always disables batch rendering for header cells.
    • Why? Because we kept seeing race conditions where we tried to sync quadrant row-header sizes before the final header cells finished rendering, leading to mismeasurements. The cost here is likely minimal,聽since header cells are less numerous than body cells and generally won't have tons of content in them (e.g. they won't have huge JSON blobs or detectTruncation logic).

@blueprint-bot
Copy link

Delete Batcher code

Preview: documentation | table
Coverage: core | datetime

@llorca
Copy link
Contributor

llorca commented Oct 6, 2017

Feels pretty good for column headers. Is it now also disabled for row headers? They don't particularly feel that much faster

Copy link
Contributor

@gscshoyru gscshoyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...well that's straightforward enough

Copy link
Contributor

@giladgray giladgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice deletions

@cmslewis
Copy link
Contributor Author

cmslewis commented Oct 6, 2017

@llorca yep, it's disabled in the generic Header component, which both row and column headers use internally.

@cmslewis cmslewis merged commit 9815a28 into master Oct 6, 2017
@cmslewis cmslewis deleted the cl/table-disable-batch-rendering-in-headers branch October 6, 2017 18:47
@cmslewis cmslewis mentioned this pull request Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants