copyright comments use /* only #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more commentsPreview: documentation | landing | table |
llorca
approved these changes
Mar 19, 2018
|
@llorca updated description with answer |
giladgray
commented
Mar 19, 2018
| @@ -8,6 +8,8 @@ $banner-height: $pt-grid-size * 4; | |||
|
|
|||
| // banner along top of screen linking to v2 docs | |||
| .docs-banner { | |||
| flex: 0 0 auto; | |||
There was a problem hiding this comment.
oh this should fix the banner issue
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #2266
fixes some issues where entities would have the copyright statement as their documentation.
why?
/**is a JSDoc comment, meaning it contains useful user-facing documentation. Tools like VS Code and Typedoc will pick up/**comments and display them in tooltips etc./*is a simple block comment, meaning it contains a comment about some code and can span multiple lines.⇒ These copyright blocks should be block comments as they are not documentation.