Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide nested content for .pt-skeleton #2284

Merged
merged 1 commit into from Mar 20, 2018

Conversation

Projects
None yet
3 participants
@giladgray
Copy link
Contributor

commented Mar 20, 2018

Fixes #2176

Changes proposed in this pull request:

Make all descendants of .pt-skeleton invisible, including ::before and ::after. This will hide icons when the skeleton animation shows.

馃帺 Thanks @univerio!! (#2178)

Screenshot

image

@giladgray giladgray requested review from llorca and michael-yx-wu Mar 20, 2018

@giladgray giladgray changed the title Hide nested content for .pt-skeleton, e.g. icons (thanks @univerio) Hide nested content for .pt-skeleton Mar 20, 2018

@blueprint-bot

This comment has been minimized.

Copy link
Collaborator

commented Mar 20, 2018

Hide nested content for .pt-skeleton, e.g. icons (thanks @univerio)

Preview: documentation | landing | table

@themadcreator
Copy link
Contributor

left a comment

Simple

@giladgray giladgray merged commit 9347f7e into develop Mar 20, 2018

7 checks passed

ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: deploy-preview Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: install-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
cla/palantir CLA signed via membership in "palantir"
Details

@giladgray giladgray deleted the gg/hide-skeleton-children branch Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.